chore: include cli and ws extras in dev environment #1905
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RinZ27
force-pushed
the
fix/bump-starlette
branch
2 times, most recently
from
d48df76 to
0863e2d
Compare
Kludex
reviewed
Jan 18, 2026
pyproject.toml
Outdated
| "dirty-equals>=0.9.0", | ||
| "coverage[toml]>=7.13.1", | ||
| "pillow>=12.0", | ||
| "typer>=0.16.0", |
Member
|
Dropping the constraints is not necessary. This is not a vulnerability here. |
This ensures that the dev environment has all necessary optional dependencies for running tests locally without duplication. Reverted the starlette version bump as it was deemed unnecessary for this project's context.
RinZ27
force-pushed
the
fix/bump-starlette
branch
from
0863e2d to
b66941b
Compare
RinZ27
changed the title
Author
|
I've updated the PR to address your feedback. Specifically, I've replaced the manual I've also reverted the |
Kludex
reviewed
Jan 18, 2026
Comment on lines
+58
to
+70
| "pyright>=1.1.400", | ||
| "pytest>=8.3.4", | ||
| "ruff>=0.8.5", | ||
| "trio>=0.26.2", | ||
| "pytest-flakefinder>=1.1.0", | ||
| "pytest-xdist>=3.6.1", | ||
| "pytest-examples>=0.0.14", | ||
| "pytest-pretty>=1.2.0", | ||
| "inline-snapshot>=0.23.0", | ||
| "dirty-equals>=0.9.0", | ||
| "coverage[toml]>=7.13.1", | ||
| "pillow>=12.0", | ||
| "mcp[cli,ws]", |
Member
There was a problem hiding this comment.
Can you move it to the first, and add a note, please?
Something like # We add mcp[cli,ws] so uv sync considers the extras..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've updated the
devdependency group to reference the project's owncliandwsextras. This ensures that the test environment is complete for local development without duplicating package entries.Also, I've reverted the
starletteversion bump based on the feedback that the constraint change wasn't necessary in this context.Let me know if this revised approach looks good to you.