Skip to content

Coregistration GUI modernisation (phase 6) - #14412

Open
payamsash wants to merge 5 commits into
mne-tools:mainfrom
payamsash:coreg_gui_dev_phase_4
Open

payamsash wants to merge 5 commits into
mne-tools:mainfrom
payamsash:coreg_gui_dev_phase_4

Conversation

@payamsash

Copy link
Copy Markdown
Member

Reference issue (if any)

following #14353 and phase 6 of #14141

What does this implement/fix?

  • toolbar like Brain: screenshot + help button + show/hide
  • progress bar for the ICP fitting

Additional information

Opus 5.5 helped implementing, I reviewed and iterated over it.

@payamsash
payamsash requested a review from drammock as a code owner October 13, 2026 16:04

@nordme nordme left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @payamsash ! Thanks for the PR!

I test drove this update to the coreg GUI and I have a couple comments. I like the screenshot toolbar! I'd like to request that we have the option to screenshot the whole window though, not just the head area, because in my experience often when reporting a coreg bug, it can be useful to see the values in the fitting fields.

Also, the progress bar -- it's kinda stuck oddly in the lower left hand corner for me. It doesn't bother me too much, but is this the look of the bar that you intended?

Image

@drammock

Copy link
Copy Markdown
Member

I'd like to request that we have the option to screenshot the whole window though, not just the head area, because in my experience often when reporting a coreg bug, it can be useful to see the values in the fitting fields.

whole-active-window screenshots can usually be accomplished at the OS-level (e.g. on my linux, with Alt+PrtSc).

@nordme

nordme commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

@drammock I agree it's easy on my Linux desktop, but on my Mac, I don't know any way to do it without grabbing the whole screen. I'm not the world's most proficient Mac user by any means, of course 😄 so maybe someone else knows a shortcut. I guess I was just thinking, if we do it in the GUI code, then it will be cross platform.

I don't mean to be a blockade to progress! It's not a deal breaker for moving on in my mind.

@drammock

Copy link
Copy Markdown
Member

on my Mac, I don't know any way to do it without grabbing the whole screen

apparently it's Shift+Command+4, then spacebar, then click on the window https://support.apple.com/en-us/102646

@nordme

nordme commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

apparently it's Shift+Command+4, then spacebar, then click on the window https://support.apple.com/en-us/102646

Omg Apple 🤦‍♀️ 😆 The internet informs me the window screenshot shortcut is better on Windows, at least -- Alt + PrtScn also

@payamsash

Copy link
Copy Markdown
Member Author

Hi @nordme and thank you again!

It should be fixed now. Now the bar counts up toward the max number of iterations (default is 20) and if it converges earlier, it will jump to 100%.

I also added fix to #14420 in this PR, as it was small.

Also see #14141 and let me know if you have other ideas!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants