-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
MAINT: Update dependency specifiers #13611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
larsoner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good bot 🚀
But really, nice job @tsbinns ! 👏
|
Okay failure in |
|
Okay looking here: it looks like we have two things to fix (at least)
I'll try to push some commits for this... |
|
Oh... we have no code for automatically updating |
This would be addressed in #13490 when it lands, but is still a WIP |
|
In the meantime this should be good for review @drammock , I'll fix CIs shortly but the main ideas are in here! |
| ) | ||
| for key in opt_dependencies: | ||
| opt_dependencies[key] = update_specifiers(opt_dependencies[key], package_releases) | ||
| pyproject_data["project"]["dependencies"] = core_dependencies |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tsbinns the old code both updated inplace and set vars, which is unnecessary (and led to some confusion where I assumed things were not updated inplace because the vars were set). I've changed it just to operate inplace where possible.
|
@tsbinns actually I think this would be a good one for you to review + merge if you're happy! |
|
@larsoner Sure, I'll have a look! |
Created by spec_zero GitHub action.
fix generation ofMake a note thattools/environment_old.ymltools/environment_old.ymlmight need updating, since it'll probably be reworked in use a lockfile for "old" CI job #13490 anywaymne/fixes.pyin this or another PR.git grep TODO VERSIONis a good starting point for finding potential updates (esp.sklearn1.4+)doc/changes/dev/dependency.rstas part of action