ENH: Add param to report.add_epochs to report reject/flat #12396#13186
ENH: Add param to report.add_epochs to report reject/flat #12396#13186positiveonly wants to merge 13 commits intomne-tools:mainfrom
Conversation
positiveonly
requested review from
dengemann,
drammock,
hoechenberger,
jasmainak and
larsoner
as code owners
|
Hello! 👋 Thanks for opening your first pull request here! ❤️ We will try to get back to you soon. 🚴 |
for more information, see https://pre-commit.ci
| add_projs = self.projs if projs is None else projs | ||
|
|
||
| if epochs._bad_dropped: | ||
| reject_info = f"<p><strong>Rejection Thresholds:</strong> {epochs.reject}</p>" | ||
| flat_info = f"<p><strong>Flat Thresholds:</strong> {epochs.flat}</p>" | ||
| self.add_html(reject_info + flat_info) | ||
|
|
||
| self._add_epochs( | ||
| epochs=epochs, | ||
| psd=psd, | ||
| add_projs=add_projs, | ||
| image_kwargs=image_kwargs, | ||
| topomap_kwargs=topomap_kwargs, | ||
| drop_log_ignore=drop_log_ignore, | ||
| section=title, | ||
| tags=tags, | ||
| image_format=self.image_format, | ||
| replace=replace, | ||
| ) |
There was a problem hiding this comment.
this looks wrong, why is it unindented to be outside the method?
mne/report/report.py
Outdated
| collapse=(), | ||
| verbose=None, | ||
| ): | ||
| self.projs = projs # Initialize self.projs |
There was a problem hiding this comment.
did this line need to move up? Please avoid purely cosmetic changes, it makes the important changes harder to focus on when viewing the diff.
There was a problem hiding this comment.
you've commented out an entire test file. Not OK, revert.
| @fill_doc | ||
| def _add_or_replace(self, *, title, section, tags, html_partial, replace=False): | ||
| """Append HTML content report, or replace it if it already exists. |
There was a problem hiding this comment.
why is this method being removed? it's used a bunch of times later in the file. Revert.
pyproject.toml
Outdated
| addopts = """--durations=20 --doctest-modules -rfEXs --tb=short \ | ||
| --cov=mne --cov-report=term --cov-branch \ | ||
| --doctest-ignore-import-errors --junit-xml=junit-results.xml \ |
There was a problem hiding this comment.
it's fine to change this locally if you want to see coverage results in your terminal, but don't commit those changes please. Revert.
mne/report/report.py
Outdated
| @@ -1,4 +1,4 @@ | |||
| """Generate self-contained HTML reports from MNE objects.""" | |||
| "Generate self-contained HTML reports from MNE objects." | |||
There was a problem hiding this comment.
We do want the triple-quotes here
positiveonly
force-pushed
the
epoch_nitya
branch
from
1975021 to
e48aee8
Compare
positiveonly
force-pushed
the
epoch_nitya
branch
from
d34e418 to
320d949
Compare
positiveonly
force-pushed
the
epoch_nitya
branch
from
4366a55 to
080ed31
Compare
positiveonly
force-pushed
the
epoch_nitya
branch
from
63693b2 to
12e1416
Compare
positiveonly
force-pushed
the
epoch_nitya
branch
from
f8fb354 to
c217577
Compare
positiveonly
force-pushed
the
epoch_nitya
branch
from
c3a1917 to
9fcc510
Compare
positiveonly
force-pushed
the
epoch_nitya
branch
from
d751649 to
933bb6a
Compare
for more information, see https://pre-commit.ci
|
@positiveonly still interested in working on this? The diff looks incorrect so might be easier to start from scratch...? |
|
Closing for #13617 |
4 participants
Reference issue (if any)
What does this implement/fix?
Additional information