Repository navigation
Word validation errors from the message catalog - #112
Merged
Merged
Conversation
Pydantic validation failures reached the report as Pydantic's own text: its
built-in messages ("Field required"), and our validators' hand-written
ValueErrors behind a "Value error," prefix, located at "(top level)" when a
model-level validator failed. None of it was in the catalog.
- Validators raise messages.Invalid(rule, key, **values), a ValueError
rendered from the catalog; the loaders report it at the field that failed,
keeping its fix and spec. compute_regions raises it too.
- A _pydantic catalog section words Pydantic's built-in errors by error type,
using the error's context values and {input}.
- Tests: Invalid calls are checked like err() calls; no bare ValueError may be
raised under models/; the _pydantic entries must match exactly the error
types the file models' schemas can produce; and bad files through each
loader render entirely from the catalog in strict mode.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #111. Pydantic validation failures still reached the report in Pydantic's own words, outside the message catalog. Now they come from the catalog too:
Validation error in point.yaml: concurrency — Field requiredpoint.yaml, field \concurrency`: required, but missing`Validation error in system_desc.json: (top level) — Value error, Conflicting availability values: …system_desc.json: the availability fields disagree (…)plusFix: …compute_regions) raisemessages.Invalid(rule, key, **values)instead ofValueError. The loader reports each one at the field that failed, with that message's fix and spec._pydanticcatalog section, keyed by Pydantic's error type. Templates can use the error's context values and{input}.Invalid(...)calls likeerr(...)calls and fail on any bareraise ValueErrorundermodels/. They walk the file models' core schemas so the_pydanticentries exactly match the error types those models can raise. They also run bad files through each loader in strict mode.Checks
Full suite: 1515 passed. ruff and mypy are clean.
🤖 Generated with Claude Code