Fix Python finfo.min port in quantized attention masking#369
Open
ronaldmannak wants to merge 9 commits into
Open
Fix Python finfo.min port in quantized attention masking#369ronaldmannak wants to merge 9 commits into
ronaldmannak wants to merge 9 commits into
Conversation
Contributor
Author
|
That turned out to be a little bit more complex than I thought, but should be good to go now. Also in this PR: a related CQA fix in the same KVCache method |
Contributor
Author
|
One open question: I added extensions to MLXArray and DType to this repo. You could argue those belong in MLX-Swift. Happy to open a separate PR on MLX-Swift for that |
Collaborator
Yeah, that would probably be the best approach. There is a very thin finfo on there already |
4 tasks
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fixes a likely mistranslation from Python
mlx-lminquantizedScaledDotProductAttention.The Python reference masks boolean/causal logits with
mx.finfo(scores.dtype).min, a large negative finite value that suppresses masked positions before softmax. The Swift port usedFloat.leastNormalMagnitude, which is instead a tiny positive value, so masked positions could remain competitive or dominate when valid scores are negative.This updates the Swift quantized attention mask fill value to match the intended Python semantics and adds regression coverage for masked quantized attention.
Checklist
Put an
xin the boxes that apply.pre-commit run --all-filesto format my code / installed pre-commit prior to committing changes