Fix setup wrapper quoting for multi-word args#97
Closed
ebbsanchez wants to merge 1 commit into
Closed
Conversation
Contributor
|
Hi @ebbsanchez, thanks for your interest in contributing! This project requires that pull request authors are vouched, and you are not in the list of vouched users. This PR will be closed automatically. See https://github.com/mitchellh/vouch/blob/main/CONTRIBUTING.md for more details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #94.
The setup-vouch wrapper was using Bash
printf %qto build a Nushell command string. That escaping is shell-specific, so multi-word values such as custom commit messages or denounce reasons can be split or misparsed before reaching the Nushell command.This changes the wrapper to quote arguments as Nushell double-quoted literals only when needed, while leaving command names and flags bare. It also escapes the resolved
VOUCH_LIB_DIRpath before embedding it in theusestatement.Verification:
bash -n action/setup-vouch/vouch--reason "AI slop with spaces" --write, confirming the full reason was written as one valuenu tests/run.nu --fastgit diff --check