Fix #189: apply per-role decoding config in run_trajectory#220
Open
marktech0813 wants to merge 1 commit into
Open
Fix #189: apply per-role decoding config in run_trajectory#220marktech0813 wants to merge 1 commit into
marktech0813 wants to merge 1 commit into
Conversation
marktech0813
force-pushed
the
fix/189-gittensor
branch
2 times, most recently
from
July 16, 2026 16:03
a3d1553 to
4168139
Compare
OpenAICompatiblePool loaded decoding: but never read it, so every role used session defaults. Add decoding_for(role) and wire it into run_trajectory while preserving backward-compatible defaults.
marktech0813
force-pushed
the
fix/189-gittensor
branch
from
July 16, 2026 16:04
4168139 to
5056677
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #189 — per-role
decoding:config is now applied.OpenAICompatiblePool.decoding_for(role)with fallback defaultsrun_trajectoryselects temperature/top_p/max_tokens per role from that resolverdecoding:block is presentTest plan
pytest tests/test_decoding_for.py