$ chmod +x vendor/snoreToast/snoretoast-*.exe#458
Open
mtsmfm wants to merge 1 commit intomikaelbr:masterfrom
Open
$ chmod +x vendor/snoreToast/snoretoast-*.exe#458mtsmfm wants to merge 1 commit intomikaelbr:masterfrom
mtsmfm wants to merge 1 commit intomikaelbr:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #353.
Problem
In WSL2,
node-notifierselectsWindowsToaster(index.js:33-35), which spawnsvendor/snoreToast/snoretoast-*.exethrough Windows interop. Interop requires the executable bit on the Linux side, but the snoretoast binaries are shipped without it, so users seeDEBUG=notifieroutput but no notification.Evidence
The other shipped binaries (
notifu,terminal-notifier) already have+xin the published tarball — only snoretoast is missing it:This traces back to the git blob mode — the snoretoast files were committed as
100644(likely from a system that didn't preserve the executable bit during the upgrades in8f01da4/54ddb7f), whilenotifuwas added correctly as100755:Fix
chmod +xthe two files and commit, so the git blob mode flips to100755and the next publish picks it up.