chore(ci): move to Node 24 LTS, drop EOL Node 20 - #203
Merged
Merged
Conversation
Node 20 reached end-of-life 2026-04-30. Both build workflows now run Node 24 (active LTS); engines tightened to >=24.3.0 since only dev machines and CI build this app. screenshots/frame tool floor bumped to match.
There was a problem hiding this comment.
Pull request overview
Moves the app, screenshot tooling, and CI workflows from Node 20 to Node 24.
Changes:
- Raises app and screenshot tool requirements to Node
>=24.3.0/>=24. - Updates Android and iOS workflows to Node 24.
- Synchronizes the root lockfile metadata.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Summary | Review notes |
|---|---|---|
screenshots/frame/package.json |
Raises screenshot tooling’s Node floor. | Nit (3 votes): regenerate the nested lockfile and update the stale README prerequisite. |
package.json |
Requires Node >=24.3.0. |
— |
package-lock.json |
Updates root engine metadata. | — |
.github/workflows/build-ios-from-expo.yml |
Uses Node 24 for iOS builds. | — |
.github/workflows/build-android-from-expo.yml |
Uses Node 24 for Android builds. | — |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| ], | ||
| "package": "com.mieweb.pulse", | ||
| "versionCode": 20003 | ||
| "versionCode": 20004 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node 20 reached end-of-life on 2026-04-30, so this moves the app to the current active LTS.
20→24engines.node:^20.19.4 || ^22.13.0 || >=24.3.0→>=24.3.0(only dev machines and CI build this app; both are on 24)>=24to matchThe pulsevault submodule keeps
engines >=22intentionally (published package; Meteor consumers bundle Node 22 LTS, in maintenance until Apr 2027) — that change is mieweb/pulsevault#60, and the submodule pointer here is untouched until it merges.Validated on Node 24.16.0: install clean (no engines warnings),
tsc --noEmitclean, full jest suite green, expo-doctor 21/21.Also bumps the app to 2.0.4 (
versionin app.json/package.json/lockfile,versionCodebase 20003 → 20004) so both release workflows can ship the next build after merge — 2.0.3 went out as versionCode 20007 via manual console upload, and with the run-number offset the next CI build lands above it.