Support engine override, support overriding some env, and improve macOS compatibility#14
Open
dvicory wants to merge 1 commit intomidzelis:mainfrom
Open
Conversation
Author
|
This has been fixed. I've tested installing in playground using the default options as well as converting to being encrypted. This script is quite magnificent. Amazing work! I do have another fix for an issue I encountered generating |
…OS compatibility With the latest Docker on Homebrew, build no longer works. It seems an engine override is a nice addition, in case you prefer to not select docker as the default choice. Additionally, to allow forks to be more maintainable, allow the docker tag, repository, ZBM, and EFI to be changed through env. These are exposed through env since most users should not customize these. Use the latest released ZBM as the default. Improve macOS compatibility by using GNU versions for du and stat. inject (stat), and iso (du) are fixed by checking for GNU versions. Signed-off-by: Daniel Vicory <dvicory@gmail.com>
156feed to
1f44a81
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the latest Docker on Homebrew, build no longer works. It seems an engine override is a nice addition, in case you prefer to not select docker as the default choice.
Additionally, to allow forks to be more maintainable, allow the docker tag, repository, ZBM, and EFI to be changed through env. These are exposed through env since most users should not customize these.
Use the latest released ZBM as the default.
Improve macOS compatibility by using GNU versions for du and stat. inject (stat), and iso (du) are fixed by checking for GNU versions.
Before engine override/macOS fixes
builderwith latest Dockerinjectiso