Fix the case where the symlink is in the install directory - #6562
Merged
Merged
Conversation
Member
Author
|
Kaleb Luedtke (@Trenly) I tried to assign you as a reviewer, but GH is not being my friend today... |
Kaleb Luedtke (Trenly)
approved these changes
Sep 24, 2026
Kaleb Luedtke (Trenly)
left a comment
Kaleb Luedtke (Trenly)
left a comment
Contributor
There was a problem hiding this comment.
Thank you!!I I wasn't aware the symlink could ever end up in the installdir
ranm-msft
approved these changes
Sep 26, 2026
ranm-msft
left a comment
ranm-msft
left a comment
Contributor
There was a problem hiding this comment.
Small and clear. Handling the case where the symlink already lives in the install directory is the right fix, and the change is contained enough to be easy to reason about.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📖 Description
Follow up to #6308.
Fixes the case where the symlink is in the install directory. The computed hard link path would just be the symlink path again. Also probes the hard link via functions that won't follow any symlink that might be there instead.
🔍 Validation
Tests that failed on my machine now pass.
Microsoft Reviewers: Open in CodeFlow