Repository navigation
Azure artifact signing with new az-sign command #595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
0256824
azure artifact signing draft
zateutsch 2157a7c
auth headache
zateutsch bf01691
Merge branch 'main' into zt/359-azure-signing
zateutsch 1697d9d
local pr review findings
zateutsch bd324f2
Merge branch 'main' into zt/359-azure-signing
zateutsch 49fa1b2
fix codeql warning
zateutsch ffb8cd3
Merge branch 'zt/359-azure-signing' of https://github.com/microsoft/w…
zateutsch f6ed393
Merge branch 'main' into zt/359-azure-signing
zateutsch 04d5744
address copilot feedback and add profile type to profile options lsit
zateutsch 01e3a54
Merge branch 'main' into zt/359-azure-signing
zateutsch 9349af0
Address PR review findings for Azure Trusted Signing
zateutsch 7ec59eb
Address second-pass PR review findings for Azure Trusted Signing
zateutsch 97df5c3
Harden Azure signing: cwd-subtree az.cmd guard, pagination cycle guar…
zateutsch 0cbe49c
Wrap az-login token retry, clean metadata temp on failure, add proces…
zateutsch 4e7d493
Validate ARM pagination host, scan all where.exe hits, add coverage
zateutsch 344bd59
Seam+test where.exe candidate selection, add az-sign to npm README
zateutsch 16088f3
Address PR #595 review comments for Azure signing
zateutsch d7b0ee4
Merge remote-tracking branch 'origin/main' into zt/359-azure-signing
zateutsch ee3e36c
Address PR review comments: role names, CI path optimization, dispose…
zateutsch df0492c
Address PR review: metadata endpoint validation, profile checks, docs…
zateutsch f6c44c8
Address PR review: least-privilege CI guidance, portal wording, npm w…
zateutsch d2b289c
Use Path.Join instead of Path.Combine in remaining flagged locations
zateutsch 7344daa
az-sign: direct-GET profile validation, validated-path CLI auth, cach…
invalid-email-address fa8a18b
az-sign: verify dlib integrity, login on metadata-file path, doc all …
invalid-email-address 272fe59
Use filtered exception catches; document VC++ Redistributable prerequ…
invalid-email-address d8c7892
Use ternary assignment for choices and url branches
invalid-email-address 53375b6
Potential fix for pull request finding 'Generic catch clause'
zateutsch 8722991
Potential fix for pull request finding 'Generic catch clause'
zateutsch 7cf646c
Honor existing Azure CLI session in non-interactive environments
invalid-email-address 12e7017
Fix malformed XML doc comment on IsValidTenantId
invalid-email-address d3607c0
Harden signtool working directory, fix ARM pagination and deadlock test
invalid-email-address c48a280
Harden signtool dlib az resolution and add ProcessRunner .cmd regress…
invalid-email-address d824916
Clarify that az-sign metadata mode only skips discovery/selection, no…
invalid-email-address 5a64f0c
Filter ProcessRunnerTests Cleanup catch to expected filesystem except…
invalid-email-address fa966c1
Propagate cancellation from the Trusted Signing dlib install
invalid-email-address f53af3f
Validate full metadata shape before any Azure work in az-sign
invalid-email-address 6478fb0
Fix flaky update notice gating assertion
Copilot 32a8d0b
Dispose ARM responses, drain reads on cancel, document timestamp URL
invalid-email-address 7c58bf2
Potential fix for pull request finding
zateutsch 2678976
Use model-based selection prompts and fix AzureAuthService formatting
invalid-email-address ddc39ac
address nikola PR review
zateutsch File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.