Skip to content

fix: resolve npm CLI platform binary#356

Open
janechu wants to merge 1 commit into
mainfrom
users/janechu/fix-macos-runtime
Open

fix: resolve npm CLI platform binary#356
janechu wants to merge 1 commit into
mainfrom
users/janechu/fix-macos-runtime

Conversation

@janechu

@janechu janechu commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Replace the root @microsoft/webui native bin with a JavaScript launcher that resolves the current platform package at runtime.
  • Add platform-suffixed bin entries so npm publishes platform package binaries with executable permissions.
  • Update publish staging, docs, and tests to cover launcher dispatch and executable binary staging.

Validation

  • pnpm --filter @microsoft/webui test
  • cargo test -p xtask stage_file_sets_executable_permissions_when_requested
  • npm tarball checks confirmed root bin packs the JS launcher and macOS platform bin packs with executable mode.
  • cargo xtask check

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@janechu janechu marked this pull request as ready for review June 18, 2026 22:33

@mohamedmansour mohamedmansour left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want to have a JS middleware to launch the rust cli, that is against the point, we basically copy the native library to the bin so that it directly goes to native instead of proxying the hop through JS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants