Repository navigation
tests: revert JSON integration runner wiring - #336896
Closed
Dmitriy Vasyura (dmitrivMS) wants to merge 1 commit into
Closed
Dmitriy Vasyura (dmitrivMS) wants to merge 1 commit into
Dmitriy Vasyura (dmitrivMS) wants to merge 1 commit into
Conversation
Partially revert #336754 in the shared integration runners after the JSON suite wiring broke official builds. Restore only the two scripts to their pre-change versions. Keep the JSON URL/cache fixes and regression test files in place; repair the test integration separately. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot started reviewing on behalf of
Dmitriy Vasyura (dmitrivMS)
September 19, 2026 22:32
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The checked-in integration-test documentation still advertises the now-unsupported JSON suite.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Reverts JSON suite wiring from shared integration runners to restore official-build compatibility.
Changes:
- Removes JSON suite registration and execution from Bash and Windows runners.
- Restores both scripts to their pre-#336754 behavior.
| File | Description |
|---|---|
scripts/test-integration.sh |
Removes JSON suite support from the Bash runner. |
scripts/test-integration.bat |
Removes JSON suite support from the Windows runner. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
|
||
| # Known suite names (used for help text and validation) | ||
| KNOWN_SUITES="api-folder api-workspace colorize terminal-suggest typescript markdown emmet git git-base ipynb notebook-renderers configuration-editing github-authentication copilot css html json" | ||
| KNOWN_SUITES="api-folder api-workspace colorize terminal-suggest typescript markdown emmet git git-base ipynb notebook-renderers configuration-editing github-authentication copilot css html" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial revert of #336754 to restore the previous integration-runner behavior after the JSON suite wiring broke official builds.
This reverts only the changes to
scripts/test-integration.batandscripts/test-integration.sh:jsonfrom the suite lists.The JSON URL/cache fixes, regression test files, and all other changes remain intact. The official-build-compatible test integration will be fixed separately.
Validation
This PR is intentionally limited to the two runner scripts.