build: align telemetry validation across CI and official builds - #336865
Merged
Ladislau Szomoru (lszomoru) merged 3 commits intoSep 19, 2026
Merged
Conversation
Resolve standalone extractor invocations from the root lockfile instead of independent or floating versions. Run the PR metadata gate through the official scoped extraction script so core and extension namespaces are not combined, installing only the extractor outside the workspace. Propagate Copilot extractor failures and reconcile the duplicated cloud session creation duration description. Add regression coverage for version drift, extraction scope, failure propagation and compatible outcome metadata. Refs #336369, #336747, #336857 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Dmitriy Vasyura (dmitrivMS)
added
vscode-build
Dmitriy Vasyura (dmitrivMS)
requested review from
Alexandru Dima (alexdima),
Logan Ramos (lramos15) and
Ladislau Szomoru (lszomoru)
as code owners
September 18, 2026 23:54
Dmitriy Vasyura (dmitrivMS)
requested review from
TylerLeonhardt and
Sandeep Somavarapu (sandy081)
as code owners
September 18, 2026 23:54
Dmitriy Vasyura (dmitrivMS)
added
the
engineering
Dmitriy Vasyura (dmitrivMS)
requested review from
Michael Lively (Yoyokrazy) and
Raymond Zhao (rzhao271)
as code owners
September 18, 2026 23:54
Copilot started reviewing on behalf of
Dmitriy Vasyura (dmitrivMS)
September 18, 2026 23:54
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The workflows, official build path, metadata correction, and focused regression coverage are consistent and complete.
Review effort: Balanced
Findings: None
What changed in this PR
Aligns telemetry extraction versions and behavior across PR validation and official builds.
Changes:
- Resolves extractor versions from the root lockfile.
- Reuses official extraction scopes and propagates failures.
- Aligns conflicting Copilot telemetry metadata and adds regression tests.
| File | Description |
|---|---|
.github/workflows/telemetry.yml |
Uses locked extractor and official extraction script. |
.github/workflows/pr.yml |
Aligns Copilot validation with the lockfile. |
build/azure-pipelines/common/extract-telemetry.ts |
Supports externally installed extractor. |
build/azure-pipelines/product-copilot.yml |
Pins extraction and propagates failures. |
build/lib/test/telemetryExtractorVersion.test.ts |
Adds consistency and failure regression coverage. |
extensions/copilot/src/extension/chatSessions/vscode-node/cloudBackendTelemetry.ts |
Unifies duration metadata descriptions. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Honor the repository's no-in-operator lint rule in the new telemetry consistency regression test. The targeted tests and ESLint check pass. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Remove the standalone test file as requested; keep the validated CI and official-build changes unchanged. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
TylerLeonhardt
approved these changes
Sep 19, 2026
Joaquín Ruales (jruales)
approved these changes
Sep 19, 2026
Ladislau Szomoru (lszomoru)
approved these changes
Sep 19, 2026
Ladislau Szomoru (lszomoru)
deleted the
agents/align-telemetry-ci-version
branch
September 19, 2026 07:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #336369. Follow-up to #336747 and #336857.
Problem
PR #336704's passing metadata job executed extractor 1.14.0, while official builds now use 1.20.5. The Copilot PR gate independently pinned 1.20.4, and its official packaging step requested an unversioned extractor and ignored nonzero exit codes.
Updating the version alone also exposes two issues: the general gate combines unrelated core/extension namespaces, and Copilot has conflicting descriptions for the same
copilotcloud.chat.sessionCreate.durationMsproperty.Changes
The official build's existing heap setting remains unchanged. No validation is disabled.
Validation
Ran the actual updated YAML commands locally on Node 24.18.0 / Windows with Git Bash, using the published 1.20.5 package and no repository dependencies installed:
git diff --checkpass.This branch includes the merged #336857 fix. These are local execution results, not a claim that remote CI has completed; no manual CI/Azure rerun or infrastructure change was requested.