Refactor: move Teams activity types to Handlers namespace#386
Merged
Refactor: move Teams activity types to Handlers namespace#386
Conversation
Reorganize Teams activity classes (e.g., MessageActivity, InvokeActivity, EventActivity, etc.) from the Schema namespace into the new Handlers namespace and file structure. Update all relevant usings and references throughout the codebase. No functional changes—this improves code organization and maintainability by clarifying the separation between schema definitions and activity handlers. Also includes minor clarity improvements in StreamingWriter.
Reorganize Teams bot schema and handler classes by moving them from Microsoft.Teams.Bot.Apps.Schema to feature-specific namespaces under Microsoft.Teams.Bot.Apps.Handlers, including MessageExtension and TaskModules. Update using statements and file locations accordingly. No functional changes; improves code organization and maintainability.
Reorganized entity-related classes (e.g., CitationEntity, MentionEntity, etc.) from Microsoft.Teams.Bot.Apps.Schema to the new Microsoft.Teams.Bot.Apps.Schema.Entities namespace. Updated all relevant using directives and imports across the codebase and tests. No functional changes; this improves code structure and maintainability.
singhk97
approved these changes
Mar 23, 2026
Collaborator
singhk97
left a comment
singhk97
left a comment
There was a problem hiding this comment.
Nice refactor, separating incomming and outgoing activities into different namespaces makes it easier to know when to use what.
- Added SuggestedAction/SuggestedActions classes with serialization and unit tests; enabled quick reply buttons in bot messages - MessageActivity/TeamsActivity now support SuggestedActions; builder supports WithSuggestedActions - Added "suggested" and improved "help" handlers to demonstrate suggested actions - Introduced WelcomeMessageMiddleware for first-turn onboarding - "card" command now sends a TimeOffRequestCard adaptive card; added OnMessageSubmitAction handler - Refactored ConversationUpdateHandler: clarified channel event registration, fixed event type strings, enabled member add/remove handlers - Added LoggerExtensions for guarded logging; replaced direct logging calls - Updated README with event trigger instructions and manifest guidance - Removed catch-all echo handler; improved null checks and copyright headers - Ensured collection properties are writable for serialization
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reorganize Teams activity classes (e.g., MessageActivity, InvokeActivity, EventActivity, etc.) from the Schema namespace into the new Handlers namespace and file structure. Update all relevant usings and references throughout the codebase. No functional changes—this improves code organization and maintainability by clarifying the separation between schema definitions and activity handlers. Also includes minor clarity improvements in StreamingWriter.
One benefit of this organization for activities, is that make it clear which activities are incoming from the handlers, and which ones are outgoing in Schema.