[Terminal] Improve StringBufferTerminalProvider snapshot testing ergonomics.
#5530
+714
−1,472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iclanton
requested review from
D4N14L,
apostolisms,
dmichon-msft and
octogonz
as code owners
iclanton
changed the title
StringBufferTerminalProvider snapshot testing ergonomics.
iclanton
force-pushed
the
StringBufferTerminalProvider-snapshot-ergonomics
branch
from
e527f3c to
0964230
Compare
| /** | ||
| * @beta | ||
| */ | ||
| export interface IAllStringBufferOutput { |
Contributor
There was a problem hiding this comment.
This model is incomplete and allows drift in real-world output without breaking snapshots. We should really just buffer the raw chunks in sequence, merging consecutive chunks of the same severity, and run snapshots against that. It's rather important for our snapshot tests to capture the relative ordering of chunks of different severities, since that reflects what the user sees.
Member
Author
There was a problem hiding this comment.
True, but this isn't a change to what currently exists. That would be a different testing API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a
getAllOutputfunction toStringBufferTerminalProviderthat returns an object containing all output severities.How it was tested
Updated a bunch of tests.
Impacted documentation
None.