fix(api-extractor): preserve export keyword for namespace re-exports #5517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a namespace contains `export { Foo, Bar };` re-export declarations,
api-extractor was incorrectly stripping the `export` keyword, producing
`{ Foo, Bar, };` which is syntactically invalid TypeScript (TS1109).
This fix checks if an ExportKeyword is part of an ExportDeclaration that
is inside a ModuleBlock (namespace body), and if so, preserves it instead
of stripping it.
Fixes microsoft#5516
ItsChrisHickman
requested review from
D4N14L,
apostolisms,
dmichon-msft,
iclanton and
octogonz
as code owners
Author
|
@microsoft-github-policy-service agree |
ItsChrisHickman
force-pushed
the
fix/api-extractor-namespace-export-keyword
branch
from
39fd3ef to
b776182
Compare
iclanton
approved these changes
Dec 28, 2025
| break; | ||
|
|
||
| case ts.SyntaxKind.ExportKeyword: | ||
| // Check if this export keyword is part of an ExportDeclaration inside a namespace |
Member
There was a problem hiding this comment.
Can you deduplicate this and the other instance of this same code in the API report generator?
iclanton
reviewed
Dec 28, 2025
| span.modification.skipAll(); | ||
| break; | ||
|
|
||
| case ts.SyntaxKind.DefaultKeyword: |
Member
There was a problem hiding this comment.
Does the default need to be retained in these cases as well?
Member
|
This looks good overall to me. @octogonz should take a look as well, though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5516
When a namespace contains
export { Foo, Bar };re-export declarations, api-extractor was incorrectly stripping theexportkeyword, producing{ Foo, Bar, };which is syntactically invalid TypeScript.Input:
Before (invalid):
After (valid):
Details
The issue is in
DtsRollupGenerator.tsandApiReportGenerator.ts. Both files unconditionally skip allExportKeywordtokens (lines ~272-276), then re-add them for declaration types (interface, class, enum, namespace, function, type). However,ExportDeclarationnodes (likeexport { Foo }) were not handled, so theexportkeyword was stripped but never restored.The fix checks if an
ExportKeywordis part of anExportDeclarationthat is inside aModuleBlock(namespace body), and if so, preserves it.How it was tested
export { }declarations