Skip to content

fix(firefox): fix test timeouts after #41224#41336

Open
dcrousso wants to merge 1 commit into
microsoft:mainfrom
dcrousso:fix-41224-timeout
Open

fix(firefox): fix test timeouts after #41224#41336
dcrousso wants to merge 1 commit into
microsoft:mainfrom
dcrousso:fix-41224-timeout

Conversation

@dcrousso

Copy link
Copy Markdown
Contributor

limit when Page.navigationCommitted should be treated as a Page.sameDocumentNavigation to only if the url and frameId match a known active navigation

without these, we end up rerouting more than intended to handle the original process-swap scenario

should fix #41224 (comment)

limit when `Page.navigationCommitted` should be treated as a `Page.sameDocumentNavigation` to only if the `url` and `frameId` match a known active navigation

without these, we end up rerouting more than intended to handle the original process-swap scenario
@dcrousso dcrousso requested review from dgozman and yury-s June 17, 2026 01:49
@dcrousso dcrousso added the CQ1 label Jun 17, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Test results for "MCP"

2 failed
❌ [chrome] › mcp/cli-core.spec.ts:189 › dialog-accept @mcp-macos-latest-chrome
❌ [chrome] › mcp/annotate.spec.ts:57 › should capture multiple screenshots in one annotation @mcp-windows-latest-chrome

7352 passed, 1122 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

4 flaky ⚠️ [chromium-library] › library/video.spec.ts:337 › screencast › should work for popups `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/video.spec.ts:717 › screencast › should work with video+trace `@chromium-ubuntu-22.04-node22`
⚠️ [firefox-library] › library/inspector/cli-codegen-3.spec.ts:224 › cli codegen › should generate frame locators (4) `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-page] › page/page-emulate-media.spec.ts:144 › should keep reduced motion and color emulation after reload `@firefox-ubuntu-22.04-node20`

39599 passed, 743 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests others"

1 fatal errors, not part of any test

1 flaky ⚠️ [electron-api] › electron/electron-tracing.spec.ts:56 › should respect tracesDir and name `@electron-macos-latest`

20001 passed, 647 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 2"

1 failed
❌ [firefox-library] › library/defaultbrowsercontext-2.spec.ts:139 › should create userDataDir if it does not exist @firefox-macos-15-large

23 flaky ⚠️ [chromium-library] › library/chromium/chromium.spec.ts:177 › serviceWorker(), and fromServiceWorker() work `@tracing-chromium`
⚠️ [chromium-library] › library/har-websocket.spec.ts:221 › should attach websocket messages for a still open websocket after stopping `@tracing-chromium`
⚠️ [chromium-library] › library/inspector/cli-codegen-java.spec.ts:24 › should print the correct imports and context options `@chrome-ubuntu-22.04`
⚠️ [chromium-page] › page/page-network-request.spec.ts:91 › should get the same headers as the server `@msedge-windows-latest`
⚠️ [chromium-library] › library/video.spec.ts:717 › screencast › should work with video+trace `@chromium-windows-latest`
⚠️ [chromium-library] › library/heap.spec.ts:203 › cycle handles `@chromium-macos-15-large`
⚠️ [chromium-library] › library/video.spec.ts:645 › screencast › should capture full viewport `@chromium-macos-15-xlarge`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:177 › serviceWorker(), and fromServiceWorker() work `@chrome-beta-ubuntu-22.04`
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:189 › launchServer › should ignore page.pause when headed `@chrome-macos-latest`
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:294 › launchServer › disconnected event should be emitted when browser is closed or server is closed `@chrome-macos-latest`
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:431 › launchServer › should reject waitForEvent before browser.close finishes `@chrome-macos-latest`
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:1117 › launchServer only › should be able to reconnect to a browser 12 times without warnings `@chrome-macos-latest`
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:299 › should report intercepted service worker requests in HAR `@chrome-macos-latest`
⚠️ [chromium-page] › page/locator-frame.spec.ts:272 › should work with COEP/COOP/CORP isolated iframe `@chrome-macos-latest`
⚠️ [firefox-page] › page/page-emulate-media.spec.ts:144 › should keep reduced motion and color emulation after reload `@tracing-firefox`
⚠️ [firefox-library] › library/inspector/cli-codegen-csharp.spec.ts:245 › should print a valid basic program in mstest `@firefox-macos-15-large`
⚠️ [firefox-library] › library/screenshot.spec.ts:213 › page screenshot › should not hang when event loop is blocked `@firefox-macos-15-large`
⚠️ [firefox-library] › library/screenshot.spec.ts:213 › page screenshot › should not hang when event loop is blocked `@firefox-macos-15-xlarge`
⚠️ [webkit-library] › library/har-websocket.spec.ts:221 › should attach websocket messages for a still open websocket after stopping `@tracing-webkit`
⚠️ [webkit-library] › library/video.spec.ts:275 › screencast › should capture navigation `@webkit-macos-15-xlarge`
⚠️ [webkit-page] › page/page-autowaiting-basic.spec.ts:58 › should await form-get on click `@webkit-macos-15-large`
⚠️ [android-page] › page/page-goto.spec.ts:71 › should work with cross-process that fails before committing
⚠️ [android-page] › page/page-goto.spec.ts:451 › should disable timeout when its set to 0

93612 passed, 4115 skipped


Merge workflow run.

@dgozman dgozman left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like what we are doing here. What's the symptom we are trying to fix? Perhaps we should make launchPersistentContext() wait for all pages to be restored? Or make sure that our navigation issued through Juggler has a priority over anything else going in the browser? I think we are trying to fix a symptom, and not with an elegant solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants