Open
Conversation
tjones60
added
the
release-ci-required
Contributor
There was a problem hiding this comment.
Pull request overview
This PR increases parallelism for vmm_tests by reducing nextest thread reservations per test (reflecting that many guest VPs are idle), and standardizes processor-topology configuration by introducing reusable “heavy” presets.
Changes:
- Adjust
.config/nextest.tomlthreads-requiredoverrides to allow morevmm_teststo run concurrently. - Add
ProcessorTopology::heavy()/ProcessorTopology::very_heavy()helpers and update multiple tests to use them. - Clarify VP-count selection logic in
memstattests based on(isolation_type, machine_arch).
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
vmm_tests/vmm_tests/tests/tests/x86_64/openhcl_uefi.rs |
Switch heavy/very-heavy tests to use the new ProcessorTopology presets. |
vmm_tests/vmm_tests/tests/tests/multiarch/vmbus_relay.rs |
Use ProcessorTopology::heavy() for the heavy vmbus relay test. |
vmm_tests/vmm_tests/tests/tests/multiarch/memstat.rs |
Make large-VM VP-count selection explicit by isolation type and architecture. |
vmm_tests/vmm_tests/tests/tests/multiarch.rs |
Use ProcessorTopology::heavy() for the heavy boot test. |
petri/src/vm/mod.rs |
Introduce reusable ProcessorTopology::heavy() and ::very_heavy() constructors. |
.config/nextest.toml |
Reduce per-test thread reservations for vmm_tests (including heavy/very-heavy filters) to increase CI concurrency. |
smalis-msft
reviewed
Apr 3, 2026
| 64 | ||
| } | ||
| } | ||
| TestVPCount::LargeVPCount => match (isolation_type, machine_arch) { |
Contributor
There was a problem hiding this comment.
@ Daniel Paulius is this change ok? This will presumably affect the baselines here.
smalis-msft
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow tests to run with less threads reserved, since many of the threads are often idle. This allows more tests to run in parallel, improving CI times.
Also standardizes and clarifies some processor configuration.