xtask: Convert workspacing checks to new lint structure#3172
Open
smalis-msft wants to merge 1 commit intomicrosoft:mainfrom
Open
xtask: Convert workspacing checks to new lint structure#3172smalis-msft wants to merge 1 commit intomicrosoft:mainfrom
smalis-msft wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Moves the “verify workspace Cargo.toml workspacing” checks from a standalone xtask pass into the shared lint framework, avoiding filesystem traversal and cargo metadata for faster runs.
Changes:
- Removed the
VerifyWorkspacefmt pass and its filesystem/cargo metadataimplementation. - Added a new
workspacedlint that validates workspace membership/dependency/exclusion and checks for non-workspaced dependencies. - Updated lint error reporting to log using
self.pathrather thanworkspace_dir.join(self.path).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| xtask/src/tasks/fmt/workspace.rs | Removes the old workspace verification task implementation (walk FS + cargo metadata). |
| xtask/src/tasks/fmt/mod.rs | Drops the VerifyWorkspace fmt pass and module wiring. |
| xtask/src/tasks/fmt/lints/workspaced.rs | Introduces a new lint implementing workspace/member/dependency checks and dependency workspacing validation. |
| xtask/src/tasks/fmt/lints.rs | Registers the new lint and adjusts error logging to use self.path. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now it doesn't have to traverse the filesystem itself or run
cargo metadata, which saves us about half a second.