logview: Removing the old logviewer#3171
Open
gurasinghMS wants to merge 2 commits intomicrosoft:mainfrom
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the legacy Petri log viewer (static HTML/JS) and consolidates the “new” Vite/React-based viewer into petri/logview/, updating the Flowey GH Pages publishing pipeline to only ship the new viewer at /test-results/.
Changes:
- Replaces the old
index.html/test.html/inspect.htmlimplementation with a React SPA (Vite + React Router + TanStack Table/Virtual). - Adds Tailwind/PostCSS + Vite build configuration and a build-time copyright header injection.
- Updates Flowey jobs to build/publish the new viewer from
petri/logviewand removes publishing of the “old” viewer.
Reviewed changes
Copilot reviewed 8 out of 51 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| petri/logview/vite.config.ts | Adds Vite config, base path, and a Rollup bundle header plugin |
| petri/logview/tsconfig.json | TS compiler settings for the SPA |
| petri/logview/tailwind.css | Tailwind entry + base font styling |
| petri/logview/tailwind.config.cjs | Tailwind config (preflight disabled) |
| petri/logview/postcss.config.cjs | PostCSS config for Tailwind + autoprefixer |
| petri/logview/package.json | Declares SPA dependencies/scripts |
| petri/logview/README.md | Updates setup docs to point to petri/logview (not logview_new) |
| petri/logview/index.html | Replaces legacy HTML with SPA shell loading src/main.tsx |
| petri/logview/common.js | Removes old shared helper JS (legacy viewer) |
| petri/logview/test.html | Removes old log viewer page (legacy viewer) |
| petri/logview/inspect.html | Removes old inspect page (legacy viewer) |
| petri/logview/src/main.tsx | SPA entry: router + query client + prefetch kickoff |
| petri/logview/src/menu.tsx | New navigation drawer/menu component |
| petri/logview/src/runs.tsx | Runs listing page (filters + search + virtualized table) |
| petri/logview/src/run_details.tsx | Run details page (tests list for a run) |
| petri/logview/src/tests.tsx | Cross-run test analysis page + “verify heavy op” gating |
| petri/logview/src/test_details.tsx | Test details page (runs where a test passed/failed) |
| petri/logview/src/log_viewer.tsx | Log viewer page with search, selection, deep links, overlays |
| petri/logview/src/inspect.tsx | React overlay port of inspect viewer (parsed + raw modes) |
| petri/logview/src/search.tsx | Reusable search input with URL sync + global shortcuts |
| petri/logview/src/virtualized_table.tsx | Shared virtualized table component using TanStack + react-virtual |
| petri/logview/src/verify_prompt.tsx | Confirmation UI for “all branches” analysis |
| petri/logview/src/data_defs.tsx | Shared TS types + concurrency constants |
| petri/logview/src/ansi_span.tsx | ANSI SGR rendering component for colored logs |
| petri/logview/src/branch_quick_filters.tsx | Defines quick filter button sets |
| petri/logview/src/contexts/verify_get_all_context.tsx | Session-scoped “verified heavy op” state |
| petri/logview/src/utils/fetch_runs_data.ts | Runs list + run details fetch/parsing + prefetching + test analysis |
| petri/logview/src/utils/fetch_logs_data.ts | Fetches/parses petri.jsonl into UI-friendly log entries |
| petri/logview/src/utils/fetch_inspect_data.ts | Fetches/parses inspect files into a tree model |
| petri/logview/src/utils/fetch_git_data.ts | GitHub PR title fetching (bulk + per-PR fallback) |
| petri/logview/src/utils/ansi.ts | ANSI helpers (style map + strip) |
| petri/logview/src/table_defs/runs.tsx | Column definitions for Runs table |
| petri/logview/src/table_defs/run_details.tsx | Column definitions for Run Details table |
| petri/logview/src/table_defs/tests.tsx | Column definitions for Tests table |
| petri/logview/src/table_defs/test_details.tsx | Column definitions for Test Details table |
| petri/logview/src/table_defs/log_viewer.tsx | Column definitions for Log Viewer table |
| petri/logview/src/styles/common.css | Shared layout/table/link styles |
| petri/logview/src/styles/runs.css | Runs-page-specific styles |
| petri/logview/src/styles/menu.css | Menu/drawer styles |
| petri/logview/src/styles/main.css | Global margin/padding reset |
| petri/logview/src/styles/virtualized_table.css | Virtualized table styling |
| petri/logview/src/styles/log_viewer.css | Severity + selection + modal styles for log viewer |
| petri/logview/src/styles/inspect.css | Inspect overlay styles |
| petri/logview/src/docs/docs.tsx | In-app docs page |
| petri/logview/src/docs/header.tsx | Docs UI header component |
| petri/logview/src/docs/shortcut.tsx | Docs shortcut row component |
| petri/logview/src/docs/shortcuts.ts | Shortcut definitions/content |
| petri/logview_new/index.html | Removes old “new viewer” shell (directory deprecation) |
| flowey/flowey_lib_hvlite/src/_jobs/build_test_results_website.rs | Builds the website from petri/logview (not logview_new) |
| flowey/flowey_lib_hvlite/src/_jobs/consolidate_and_publish_gh_pages.rs | Stops publishing “test-results-old”; publishes only /test-results |
Member
|
Logviewer is dead, long live logviewer. |
smalis-msft
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new one seems to be stable enough (Have not had issues with it in a while so assuming it is fine). Deprecating the old one.