Skip to content

netvsp & net_mana - instrument VTL0 & host calls at risk of hanging#3170

Open
ben-zen wants to merge 4 commits intomicrosoft:mainfrom
ben-zen:netvsp-span-guest-calls
Open

netvsp & net_mana - instrument VTL0 & host calls at risk of hanging#3170
ben-zen wants to merge 4 commits intomicrosoft:mainfrom
ben-zen:netvsp-span-guest-calls

Conversation

@ben-zen
Copy link
Copy Markdown
Contributor

@ben-zen ben-zen commented Apr 1, 2026

There's a bunch of async operations with long or no timeout which are at risk of hanging the NetVSP code; adding spans to those actions makes them more obvious in tracing, with additional context to track down miscreant calls or make a misbehaving VM more obvious.

@ben-zen ben-zen requested a review from a team as a code owner April 1, 2026 00:20
Copilot AI review requested due to automatic review settings April 1, 2026 00:20
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves observability around NetVSP and MANA endpoint operations that can take a long time or potentially hang, by adding tracing spans with relevant identifiers (instance/vport/VF IDs). This helps correlate stalls in async shutdown/reconfiguration paths when debugging misbehaving VMs or host/VTL0 interactions.

Changes:

  • Add an info_span around NetVSP coordinator endpoint shutdown.
  • Add info_span instrumentation around MANA endpoint teardown steps (RX disable, vport resource destruction, queue drain wait).
  • Add info_span instrumentation around Underhill VTL0 VF offer/remove notification calls, plus an explicit log when VTL0 bus isn’t present.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
vm/devices/net/netvsp/src/lib.rs Instruments coordinator endpoint stop().await with an info span including instance_id.
vm/devices/net/net_mana/src/lib.rs Adds tracing::Instrument and spans around endpoint stop/cleanup operations with vport_id.
openhcl/underhill_core/src/emuplat/netvsp.rs Adds spans around VTL0 VF removal notice and VF offer call to better pinpoint stalls and add context.

Copy link
Copy Markdown
Contributor

@erfrimod erfrimod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a comment to trace one more thing, but otherwise ready to go. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants