netvsp & net_mana - instrument VTL0 & host calls at risk of hanging#3170
Open
ben-zen wants to merge 4 commits intomicrosoft:mainfrom
Open
netvsp & net_mana - instrument VTL0 & host calls at risk of hanging#3170ben-zen wants to merge 4 commits intomicrosoft:mainfrom
ben-zen wants to merge 4 commits intomicrosoft:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves observability around NetVSP and MANA endpoint operations that can take a long time or potentially hang, by adding tracing spans with relevant identifiers (instance/vport/VF IDs). This helps correlate stalls in async shutdown/reconfiguration paths when debugging misbehaving VMs or host/VTL0 interactions.
Changes:
- Add an
info_spanaround NetVSP coordinator endpoint shutdown. - Add
info_spaninstrumentation around MANA endpoint teardown steps (RX disable, vport resource destruction, queue drain wait). - Add
info_spaninstrumentation around Underhill VTL0 VF offer/remove notification calls, plus an explicit log when VTL0 bus isn’t present.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| vm/devices/net/netvsp/src/lib.rs | Instruments coordinator endpoint stop().await with an info span including instance_id. |
| vm/devices/net/net_mana/src/lib.rs | Adds tracing::Instrument and spans around endpoint stop/cleanup operations with vport_id. |
| openhcl/underhill_core/src/emuplat/netvsp.rs | Adds spans around VTL0 VF removal notice and VF offer call to better pinpoint stalls and add context. |
erfrimod
reviewed
Apr 2, 2026
erfrimod
reviewed
Apr 2, 2026
Contributor
erfrimod
left a comment
There was a problem hiding this comment.
Added a comment to trace one more thing, but otherwise ready to go. :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's a bunch of async operations with long or no timeout which are at risk of hanging the NetVSP code; adding spans to those actions makes them more obvious in tracing, with additional context to track down miscreant calls or make a misbehaving VM more obvious.