Add filesystem policy path validation (same-path conflict, existence check, object-based conflict)#551
Open
SohamDas2021 wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds cross-list filesystem policy validation in wxc_common during config parsing to catch conflicting path intents early and provide better diagnostics for missing host paths.
Changes:
- Invoke new cross-list filesystem validation from
validate_filesystem_paths. - Implement same-path conflict detection, existence warnings, and object-based conflict checks (inode-based on Unix, canonicalization-based on Windows).
- Add unit tests for same-string conflicts across
readwritePaths/readonlyPaths/deniedPaths.
1f20aff to
33997be
Compare
Member
|
Can you add Daniel Dudugjian to this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📖 Description
Validate filesystem paths across readwritePaths, readonlyPaths, and deniedPaths at config parse time:
All checks live in wxc_common and apply to every backend.
🔗 References
🔍 Validation
✅ Checklist
📋 Issue Type
GitHub Actions runs the PR validation build automatically. The ADO pipeline
(
MXC-PR-Build) is the official build pipeline that signs the binaries; itruns on merge to
mainand nightly, and Microsoft reviewers can trigger iton a PR with
/azp run. See docs/pull-requests.md.Microsoft Reviewers: Open in CodeFlow