Skip to content

Fix unit test #823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Binyang2014 merged 3 commits into from
Jun 25, 2026
Merged

Fix unit test #823

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
addae43
ut fix
Binyang2014 Jun 25, 2026
4faf8d0
Merge branch 'main' into binyli/ut-fix
Binyang2014 Jun 25, 2026
8ae22bd
fix cov build
Binyang2014 Jun 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .azure-pipelines/templates/ut.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@ steps:
name: PyTests
displayName: Run pytests
remoteScript: |
mpirun --allow-run-as-root -tag-output -x MSCCLPP_HOME=/root/mscclpp -x GPU_MAX_HW_QUEUES=8 -np 8 python3 -m pytest ./python/test/test_mscclpp.py -x
mpirun --allow-run-as-root -tag-output -x MSCCLPP_HOME=/root/mscclpp -x GPU_MAX_HW_QUEUES=8 -np 8 python3 -m pytest ./python/test/test_fp8_accum.py -x
mpirun --allow-run-as-root -tag-output -x MSCCLPP_HOME=/root/mscclpp -x HSA_NO_SCRATCH_RECLAIM=1 -x GPU_MAX_HW_QUEUES=8 -np 8 python3 -m pytest ./python/test/test_mscclpp.py -x
Comment thread
Binyang2014 marked this conversation as resolved.
mpirun --allow-run-as-root -tag-output -x MSCCLPP_HOME=/root/mscclpp -x HSA_NO_SCRATCH_RECLAIM=1 -x GPU_MAX_HW_QUEUES=8 -np 8 python3 -m pytest ./python/test/test_fp8_accum.py -x

- template: stop.yml
parameters:
Expand Down
15 changes: 12 additions & 3 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,11 +112,20 @@ if(MSCCLPP_ENABLE_COVERAGE)
if(CMAKE_CXX_COMPILER_ID MATCHES "GNU|Clang")
message(STATUS "Code coverage enabled")

# Add coverage flags to C++ targets only (not CUDA)
add_compile_options($<$<COMPILE_LANGUAGE:CXX>:--coverage>)
# Add coverage flags to C++ targets only (not CUDA). For ROCm, keep
# coverage on the host compilation so HIP device linking does not look
# for gcov runtime symbols.
if(MSCCLPP_USE_ROCM)
add_compile_options($<$<COMPILE_LANGUAGE:CXX>:-Xarch_host>)
add_compile_options($<$<COMPILE_LANGUAGE:CXX>:--coverage>)
add_link_options($<$<LINK_LANGUAGE:CXX>:-Xarch_host>)
add_link_options($<$<LINK_LANGUAGE:CXX>:--coverage>)
else()
add_compile_options($<$<COMPILE_LANGUAGE:CXX>:--coverage>)
add_link_options($<$<LINK_LANGUAGE:CXX>:--coverage>)
endif()
add_compile_options($<$<COMPILE_LANGUAGE:CXX>:-O0>)
add_compile_options($<$<COMPILE_LANGUAGE:CXX>:-g>)
add_link_options($<$<LINK_LANGUAGE:CXX>:--coverage>)

# Find lcov
find_program(LCOV_PATH lcov)
Expand Down
2 changes: 2 additions & 0 deletions src/core/gpu_ipc_mem.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,8 @@ UniqueGpuIpcMemHandle GpuIpcMemHandle::create(const CUdeviceptr ptr) {
if (err == cudaSuccess) {
handle->typeFlags |= GpuIpcMemHandle::Type::RuntimeIpc;
} else {
// The VMM fallback below handles this failure, so do not leak it as CUDA's last error.
(void)cudaGetLastError();
WARN(GPU, "Failed to create runtime CUDA IPC handle for pointer ", (void*)basePtr,
": error=", static_cast<int>(err), " (", std::string(cudaGetErrorString(err)), ")");
}
Expand Down
Loading