fix: validate sandbox path as POSIX for Windows compatibility (#138)#170
Open
shivashanmugam wants to merge 2 commits into
Open
fix: validate sandbox path as POSIX for Windows compatibility (#138)#170shivashanmugam wants to merge 2 commits into
shivashanmugam wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #170 +/- ##
==========================================
- Coverage 65.28% 65.24% -0.05%
==========================================
Files 34 34
Lines 2394 2394
==========================================
- Hits 1563 1562 -1
- Misses 831 832 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes Windows-specific validation failure when creating Mount objects with POSIX container paths (e.g., "/var/log"), which previously were interpreted as relative on Windows due to pathlib.Path selecting WindowsPath.
Changes:
- Interpret
sandbox_pathusingPurePosixPathso POSIX absolute paths remain absolute on Windows hosts. - Add in-code rationale explaining why POSIX semantics are required for sandbox/container paths.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+60
to
+65
| # The sandbox is always a POSIX (Linux) container, so the sandbox | ||
| # path must be interpreted as a POSIX path regardless of the host OS. | ||
| # Using pathlib.Path here would resolve to WindowsPath on Windows, | ||
| # which incorrectly reports POSIX absolute paths like "/var/log" as | ||
| # relative (Windows requires a drive letter for an absolute path). | ||
| sandbox_path = PurePosixPath(self.sandbox_path) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes : #138