fix: accept LLM output when command key missing but task_done is True#161
Open
amitkuma-1234 wants to merge 1 commit into
Open
fix: accept LLM output when command key missing but task_done is True#161amitkuma-1234 wants to merge 1 commit into
amitkuma-1234 wants to merge 1 commit into
Conversation
Author
|
@microsoft-github-policy-service agree |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR intends to prevent crashes when the LLM returns task_done=True but omits the command key, by adding an early return in MicroBot.run() to skip command processing when the task is already complete.
Changes:
- Added an early-return path in
MicroBot.run()whenllm_response.task_doneisTrue. - Added logging of “final thoughts” before returning success in that early-return path.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+230
to
+240
| if llm_response.task_done is True: | ||
| if llm_response.thoughts: | ||
| logger.info( | ||
| f" LLM final thoughts: {llm_response.thoughts}", | ||
| ) | ||
| logger.info("TASK COMPLETED : %s...", task[0:15]) | ||
| return BotRunResult( | ||
| status=True, | ||
| result=llm_response.thoughts, | ||
| error=None | ||
| ) |
Comment on lines
+235
to
+240
| logger.info("TASK COMPLETED : %s...", task[0:15]) | ||
| return BotRunResult( | ||
| status=True, | ||
| result=llm_response.thoughts, | ||
| error=None | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When LLM sets task_done=True but does not include a command key,
the bot crashes while trying to process the missing command.
Fixes #78
Fix
Added early return check — if task_done is True before the main
loop, bot returns successfully without processing command.
Testing
Pass LLM response with task_done=True and no command key —
bot should return BotRunResult with status=True.