fix: prevent additional_mounts accumulating across multiple run() calls#159
Open
amitkuma-1234 wants to merge 1 commit into
Open
fix: prevent additional_mounts accumulating across multiple run() calls#159amitkuma-1234 wants to merge 1 commit into
amitkuma-1234 wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to prevent additional_mounts from accumulating duplicate entries in self.mounted when MicroBot.run() is called multiple times, avoiding repeated mounts/copies on subsequent runs.
Changes:
- Add a guard in
_mount_additional()to only append/copy a mount if it is not already present inself.mounted.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+316
to
+320
| def _mount_additional(self, mount: Mount): | ||
| if mount.mount_type != MountType.COPY: | ||
| logger.error( | ||
| "%s Only COPY mount type is supported for additional mounts for now", | ||
| LogLevelEmoji.ERROR, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When bot.run() is called multiple times, additional_mounts
accumulate in self.mounted list and are never cleared.
This causes duplicate mounts on subsequent run() calls.
Fixes #115
Fix
Added a check in _mount_additional() to only append
a mount if it doesn't already exist in self.mounted.
Testing
Call bot.run() multiple times and verify self.mounted
does not contain duplicate entries.