Skip to content

Escape CSV cells in Markdown tables#1872

Open
FU-max-boop wants to merge 1 commit into
microsoft:mainfrom
FU-max-boop:fix/csv-markdown-table-escaping
Open

Escape CSV cells in Markdown tables#1872
FU-max-boop wants to merge 1 commit into
microsoft:mainfrom
FU-max-boop:fix/csv-markdown-table-escaping

Conversation

@FU-max-boop
Copy link
Copy Markdown

Summary

  • escape pipe characters in CSV cells before rendering Markdown tables
  • normalize embedded newlines in CSV cells to <br> so a quoted multiline field stays within one table row
  • add a focused regression test for pipe and multiline cell content

Tests

  • uv run --project packages/markitdown --with pytest python -m pytest packages/markitdown/tests/test_module_misc.py::test_csv_converter_escapes_markdown_table_cells packages/markitdown/tests/test_module_vectors.py::test_convert_stream_with_hints -q
  • uv run --project packages/markitdown --with ruff ruff format --check packages/markitdown/src/markitdown/converters/_csv_converter.py packages/markitdown/tests/test_module_misc.py
  • uv run --project packages/markitdown --with ruff ruff check packages/markitdown/src/markitdown/converters/_csv_converter.py packages/markitdown/tests/test_module_misc.py
  • uv run --project packages/markitdown --with mypy python -m mypy --ignore-missing-imports packages/markitdown/src/markitdown/converters/_csv_converter.py packages/markitdown/tests/test_module_misc.py

@FU-max-boop
Copy link
Copy Markdown
Author

@microsoft-github-policy-service agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant