Use env flag for nosystemcrypto builders#2319
Open
qmuntal wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR switches nosystemcrypto CI coverage from GOEXPERIMENT=nosystemcrypto matrix entries to a dedicated builder flag that sets MS_GO_NOSYSTEMCRYPTO=1 during build/test execution.
Changes:
- Replaces nosystemcrypto matrix entries with
nosystemcrypto: trueand relies on default systemcrypto behavior otherwise. - Propagates the new builder field into generated IDs and display names.
- Sets
MS_GO_NOSYSTEMCRYPTO=1for nosystemcrypto run-stage build/test steps.
Show a summary per file
| File | Description |
|---|---|
eng/pipeline/stages/go-builder-matrix-stages.yml |
Updates builder matrix entries to use the new nosystemcrypto flag. |
eng/pipeline/stages/shorthand-builders-to-builders.yml |
Adds nosystemcrypto to builder schema, IDs, and display-name fragments. |
eng/pipeline/stages/run-stage.yml |
Displays nosystemcrypto builders and exports MS_GO_NOSYSTEMCRYPTO for relevant steps. |
eng/pipeline/stages/run-codeql.yml |
Updates schema/display-name handling for the new field. |
eng/pipeline/stages/builders-to-stages.yml |
Updates builder schema comments. |
eng/pipeline/stages/sign-stage.yml |
Updates builder schema comments. |
Copilot's findings
- Files reviewed: 6/6 changed files
- Comments generated: 1
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
gdams
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
experiment: systemcryptoflags. Systemcrypto is enabled by default, no need to explicitly set it.Motivation
GOEXPERIMENT=systemcryptosupport will be removed in Go 1.27, see Remove GOEXPERIMENT=systemcrypto #2261.Validation