Conversation
microsoft-github-policy-service
bot
added
the
Needs: Review 👀
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts PR #2013 which added a Claude Code plugin for the FinOps toolkit. The revert is being performed because post-merge review identified several issues including: replacement of CLAUDE.md with a symlink, improper file placement, symlink packaging concerns, lack of guardrails in autonomous commands, unverified content, and changelog version inconsistencies. The revert removes approximately 5,000+ lines of plugin-related code including agents, skills, commands, and reference documentation.
Changes:
- Restores original CLAUDE.md with 182 lines of build commands, architecture docs, and development patterns
- Removes entire Claude Code plugin directory and all associated files (agents, skills, commands, references)
- Removes marketplace.json and AGENTS.md symlink from repository root
- Removes Claude Code plugin v1.0 changelog entry from docs-mslearn/toolkit/changelog.md
Reviewed changes
Copilot reviewed 43 out of 44 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| CLAUDE.md | Restored from symlink to full 182-line original content with build commands and architecture docs |
| AGENTS.md | Removed symlink to copilot-instructions.md |
| .claude-plugin/marketplace.json | Removed marketplace configuration file |
| src/templates/claude-plugin/* | Removed entire plugin directory including skills, agents, commands, and references |
| src/queries/catalog/costs-enriched-base.kql | Updated documentation URL (contains hardcoded branch reference - see comment) |
| src/queries/catalog/quarterly-cost-by-resource-group.kql | Updated query description comments |
| src/queries/finops-hub-database-guide.md | Changed reference from specific catalog query to generic "CostsPlus Query" |
| docs-mslearn/toolkit/changelog.md | Removed Claude Code plugin v1.0 changelog entry |
RolandKrummenacher
approved these changes
Feb 25, 2026
MSBrett
pushed a commit
that referenced
this pull request
Feb 26, 2026
Remediate 19 review items from flanakin's post-merge review of the Claude Code plugin (reverted in PR #2023). Key changes: - Update plugin version to 13.0.0 and integrate into Update-Version.ps1 - Fix plugin.json description (FinOps is a proper noun) - Update FinOps Framework to 2025 Fx (4 principles, 2 domain names) - Move commands into ftk/ subfolder for /ftk:* namespacing - Prefix all working paths with ftk/ (visible, not .ftk/) - Replace platform detection with tool availability detection - Add phase checkpoints to mom-report, document iterative design intent - Strengthen what-if as required pre-deployment step - Fix Get-VmSkuPrice array bug (Select-Object -First 1) - Copy Get-BenefitRecommendations.ps1 from azcapman - Add FinOps alerts capability, rename to FinOps workbooks - Update changelog version to v14 - Add PR-2013-REVIEW-AUDIT.md tracking all 19 items Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts #2013 ("Add Claude Code plugin for FinOps hubs and Azure Cost Management") which was merged without full review. See PR #2013 review comments for details.
Key issues:
Package-Toolkit.ps1doesn't follow symlinksThe plugin work is valuable and should be re-submitted after addressing review feedback.
Test plan
🤖 Generated with Claude Code