Skip to content

Add parameters for noisy recommendations and rename query files#2011

Open
flanakin wants to merge 1 commit intofeatures/hubs-recsfrom
flanakin/hubs-recs-noisy
Open

Add parameters for noisy recommendations and rename query files#2011
flanakin wants to merge 1 commit intofeatures/hubs-recsfrom
flanakin/hubs-recs-noisy

Conversation

@flanakin
Copy link
Collaborator

🛠️ Description

Add enableAHBRecommendations and enableSpotRecommendations parameters to control noisy recommendation types independently. Also renames query files to follow Recommendations-Microsoft-* naming convention, adds a recommendations tab to createUiDefinition.json for the Azure portal deployment experience, and switches enableRecommendations to default off (preview).

Fixes # N/A

📋 Checklist

🔬 How did you test this change?

  • 🤏 Lint tests
  • 🤞 PS -WhatIf / az validate
  • 👍 Manually deployed + verified
  • 💪 Unit tests
  • 🙌 Integration tests

🙋‍♀️ Do any of the following that apply?

  • 🚨 This is a breaking change.
  • 🤏 The change is less than 20 lines of code.

📑 Did you update docs/changelog.md?

  • ✅ Updated changelog (required for dev PRs)
  • ➡️ Will add log in a future PR (feature branch PRs only)
  • ❎ Log not needed (small/internal change)

📖 Did you update documentation?

  • ✅ Public docs in docs (required for dev)
  • ✅ Public docs in docs-mslearn (required for dev)
  • ✅ Internal dev docs in docs-wiki (required for dev)
  • ✅ Internal dev docs in src (required for dev)
  • ➡️ Will add docs in a future PR (feature branch PRs only)
  • ❎ Docs not needed (small/internal change)

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances the FinOps hubs recommendations feature by adding granular control over potentially noisy recommendation types, standardizing naming conventions, and improving the deployment experience through the Azure portal UI.

Changes:

  • Added enableAHBRecommendations and enableSpotRecommendations parameters to allow users to opt-in to potentially noisy recommendations about Azure Hybrid Benefit and Spot VMs
  • Renamed recommendation query files from HubsRecommendations-* to Recommendations-Microsoft-* pattern and updated metadata to use PascalCase (ResourceGraph, Tenant) instead of lowercase
  • Added a new "Recommendations" tab to the Azure portal deployment UI (createUiDefinition.json) with clear descriptions of included and optional recommendations
  • Changed enableRecommendations default to false to reflect preview status
  • Improved code organization by using conditional query file loading with the union() pattern

Reviewed changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/templates/finops-hub/main.bicep Added three new parameters for recommendations control (enableRecommendations, enableAHBRecommendations, enableSpotRecommendations) and passed them to hub module
src/templates/finops-hub/modules/hub.bicep Added recommendation parameters, changed enableRecommendations default to false, removed analytics dependency requirement from recommendations condition, and passed new parameters to recommendations module
src/templates/finops-hub/modules/Microsoft.FinOpsHubs/Recommendations/app.bicep Implemented conditional query loading using union pattern, removed unused storage account resource, renamed dataset to dataset_resourceGraph (consistent casing), added case-insensitive switch logic
src/templates/finops-hub/modules/Microsoft.FinOpsHubs/Recommendations/queries/*.json Renamed all 10 query files to follow Recommendations-Microsoft-* pattern, updated metadata to use PascalCase (ResourceGraph, Tenant), changed source from "Azure Resource Graph" to "FinOps hubs" (except AdvisorCost), updated type field to match new naming
src/templates/finops-hub/createUiDefinition.json Added new recommendations tab with clear UI explaining included vs optional recommendations, permissions requirements, and parameter mappings

Comment on lines +322 to 327
module recommendations 'Microsoft.FinOpsHubs/Recommendations/app.bicep' = if (enableRecommendations) {
name: 'Microsoft.FinOpsHubs.Recommendations'
dependsOn: [
core
analytics
]
Copy link

Copilot AI Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The recommendations module has a dependency on the analytics module, but the analytics module is only deployed when useFabric or useAzureDataExplorer is true. This creates a potential deployment failure if enableRecommendations is true but both useFabric and useAzureDataExplorer are false. The dependency on analytics should be conditional or removed if recommendations don't require analytics to function.

Copilot uses AI. Check for mistakes.
"queryEngine": "ResourceGraph",
"scope": "Tenant",
"source": "FinOps hubs",
"type": "Microsoft-BackendlessAppGateways",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we prefixing the type as being "Microsoft-*"? What ties these ARG queries to Microsoft? Is it the author? Should we add an "author" property instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Needs: Review 👀 PR that is ready to be reviewed Tool: FinOps hubs Data pipeline solution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

Comments