Merged
Conversation
- Add -AsTag switch to Get-Version.ps1 that returns the full git tag (e.g., "v13") - Update Package-Toolkit.ps1 to use Get-Version -AsTag for zip filenames - Update Update-Version.ps1 to use Get-Version -AsTag for ftktag.txt Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
microsoft-github-policy-service
bot
added
Micro PR 🔬
microsoft-github-policy-service
bot
added
the
Skill: DevOps
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new -AsTag switch to the version helper script and updates packaging/versioning scripts to use git-tag style versions (for example, v13) where needed.
Changes:
- Added
-AsTagswitch toGet-Version.ps1to return a git tag format (for example,v13). - Updated
Update-Version.ps1to useGet-Version -AsTagwhen writingftktag.txt. - Updated
Package-Toolkit.ps1to useGet-Version -AsTagfor packaging output naming (but this currently impacts non-zip uses of$versiontoo).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/scripts/Get-Version.ps1 | Adds -AsTag switch and updates help text/examples. |
| src/scripts/Update-Version.ps1 | Uses Get-Version -AsTag to populate ftktag.txt (removes inline regex). |
| src/scripts/Package-Toolkit.ps1 | Switches to tag-based version for ZIP naming, but currently also changes doc/deploy/version behaviors that appear to expect semantic major.minor. |
Keep $version as semantic version (13.0) for deploy paths and ftkver.txt, and use $tag (v13) only for zip filenames. Addresses PR review feedback. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Address PR #1965 feedback: `if ($Template)` always evaluated to true since $Template defaults to "*". Changed to `$Template -ne "*"` so the message correctly shows "13.0 templates" when packaging all templates. 🤖 Generated with [Claude Code](https://claude.ai/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Collaborator
Author
|
🤖 [AI][Claude] PR Update Summary Addressed: 4 thread(s)
|
RolandKrummenacher
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠️ Description
Added
-AsTagswitch toGet-Version.ps1that returns the full git tag (e.g.,v13instead of13.0). UpdatedPackage-Toolkit.ps1to use it so zip filenames match release expectations (finops-hub-v13.zipinstead offinops-hub-v13.0.zip). UpdatedUpdate-Version.ps1to use it for writingftktag.txtinstead of inline regex.📋 Checklist
🔬 How did you test this change?
🙋♀️ Do any of the following that apply?
📑 Did you update
docs/changelog.md?📖 Did you update documentation?
🤖 Generated with Claude Code