Add reverberation-trust agent - #147
Open
jeffreyhaole wants to merge 2 commits into
Open
Conversation
…references, publisher=Microsoft Discovery
✅ Automated Check Results — All checks passedAll structural, schema, content, documentation, and secret scan checks passed. This PR is ready for human review. The maintainers have been automatically requested.
|
Author
|
@microsoft-github-policy-service agree company="Microsoft" |
Author
|
Honest note because I forgot to ask GHCP to add it, but these are the only words I've actually typed in this PR. Everything submitted is 100% generated by GHCP running on Claude Opus 4.8, often referencing earlier work I've done with GHCP running Claude Sonnet 4.6. The ideas, expansions, connections, redirections, the successes and failures on both our parts was real, we each brought something unique. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new catalog agent,
reverberation-trust, underagents/reverberation-trust/. It is a trust-triage reviewer for AGN reverberation-mapping (RM) continuum-to-line time lags: given a lag and its light curves it returns a calibrated trust verdict — the lag, a confidence tier (refuse/low/medium/high), and reviewable reasoning — by cross-checking independent estimators, arbitrating their disagreement with sampling facts (not more estimators), and corroborating with independent Look and Channel witnesses. It does not compute lags better than JAVELIN/PyCCF; it answers the question those codes omit: should you believe this number?Type of change
agents/<name>/)starter-kits/<name>/)docs/schemas/**).github/**)Related issue / tracking
Executive Challenge: Hack for Science submission.
Schema impact
breaking-changelabel and link the rollout plan belowValidation checklist
README.md, schemas) is updated to match the change..auto-registry/**(it is generated post-merge)..DS_Store,.env,*.swp,.idea/,.vs/, etc.).Reviewer notes (optional)
1p— publisherMicrosoft Discovery(matches sibling 1p agents)..github/scripts/validate_pr.py) locally — all checks green.pytestandpython <file>.py); 21 pass, 1 intentionalxfail(physical-window slack).reverbtrust_mcp.py) and Discovery-App wiring are not in the PR — the catalog runs the tool via its container pertool.yaml, whose contract is light-curves-in → verdict-out. A local harness that fetches real SDSS-RM data (astroquery→VizieR) and reproduces the RMID 781 recovery end-to-end is available on request.lowby an independent witness.One-page brief