Skip to content

fix: update deployment workflow to build and push images to acr, update model to gpt-5.4-mini#280

Merged
Roopan-Microsoft merged 8 commits into
mainfrom
psl-hb-acr-build
Jul 3, 2026
Merged

fix: update deployment workflow to build and push images to acr, update model to gpt-5.4-mini#280
Roopan-Microsoft merged 8 commits into
mainfrom
psl-hb-acr-build

Conversation

@Shubhangi-Microsoft

Copy link
Copy Markdown
Contributor

This pull request makes significant improvements to the deployment process, container registry management, and region/model support. The main changes include automating Azure Container Registry (ACR) provisioning, updating deployment instructions and scripts to reflect the new workflow, and upgrading the default OpenAI model and supported regions. Several obsolete parameters and outputs have been removed to streamline the configuration.

Deployment and Documentation Updates:

  • The deployment guide and post-deployment instructions now require building and pushing backend/frontend container images to ACR before loading data or creating agents. The documentation and scripts have been updated to reflect this new step and its commands. [1] [2] [3] [4]

Container Registry Automation:

  • The Bicep template now provisions an Azure Container Registry (ACR) as part of the deployment, configures network/security settings, and assigns managed identity pull permissions to the web apps. The web app containers are now configured to use managed identity for ACR access, and sample images are set as placeholders until the real images are built and pushed. [1] [2] [3] [4]

Model and Region Support:

  • The allowed deployment regions have expanded to include centralus and southindia. The default OpenAI model is now gpt-5.4-mini with an updated version. [1] [2]

Parameter and Output Cleanup:

  • Obsolete parameters (containerRegistryEndpoint, imageTag) and related outputs have been removed from the Bicep template and parameters files, since registry configuration is now automatic. [1] [2] [3] [4]

Monitoring Configuration:

  • Application Insights and diagnostic settings have been improved to align with monitoring best practices.## Purpose
  • ...

Does this introduce a breaking change?

  • Yes
  • No

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the deployment workflow to provision Azure Container Registry (ACR) in the infra template, require a post-provision image build/push step, and updates default model/region settings.

Changes:

  • Add ACR provisioning + switch App Services to managed-identity-based ACR pulls, with placeholder images until post-provision build/push.
  • Add Bash/PowerShell scripts and docs/hooks to build & push backend/frontend images to ACR and retarget the App Services.
  • Update allowed regions and default GPT model/version, and remove obsolete container-registry/image-tag parameters/outputs.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
src/App/src/lib/textParsers.ts Adjusts product parsing to avoid misclassifying the first product as intro text.
infra/scripts/build_push_images.sh Adds Bash script to build/push images in ACR via az acr build and update App Services.
infra/scripts/build_push_images.ps1 Adds PowerShell equivalent of the ACR build/push + App Service retargeting script.
infra/main.waf.parameters.json Removes no-longer-needed registry endpoint/image tag parameters.
infra/main.parameters.json Removes no-longer-needed registry endpoint/image tag parameters.
infra/main.bicep Provisions ACR, configures managed identity pulls, updates regions/model defaults, and refreshes monitoring wiring.
documents/DeploymentGuide.md Updates deployment instructions to include the required ACR build/push step before data/agent setup.
azure.yaml Updates postprovision messaging to include the new build/push images step.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread infra/main.bicep Outdated
Comment thread infra/main.bicep Outdated
Comment thread infra/main.bicep
Comment thread infra/scripts/build_push_images.ps1
Comment thread src/App/src/lib/textParsers.ts
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 3, 2026 11:14
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

src/App/src/lib/textParsers.ts:210

  • outroText extraction is now gated on !firstPartIsProduct. If a message starts directly with a product list (no intro) but includes trailing text after the last product image/link, that trailing text will no longer be emitted as outroText and will instead remain inside the last product section (rendered in the last product card).
  if (parts.length > 0 && !firstPartIsProduct) {
    introText = parts[0].trim();
    
    introText = introText.replace(/^###\s*[^\n]*\n?/gm, '').trim();
    

Comment thread infra/main.bicep
@Roopan-Microsoft Roopan-Microsoft merged commit 5e6bada into main Jul 3, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants