fix: update deployment workflow to build and push images to acr, update model to gpt-5.4-mini#280
Merged
Merged
Conversation
…sh instructions fix: remove unused trust policy status in Bicep file
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the deployment workflow to provision Azure Container Registry (ACR) in the infra template, require a post-provision image build/push step, and updates default model/region settings.
Changes:
- Add ACR provisioning + switch App Services to managed-identity-based ACR pulls, with placeholder images until post-provision build/push.
- Add Bash/PowerShell scripts and docs/hooks to build & push backend/frontend images to ACR and retarget the App Services.
- Update allowed regions and default GPT model/version, and remove obsolete container-registry/image-tag parameters/outputs.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/App/src/lib/textParsers.ts | Adjusts product parsing to avoid misclassifying the first product as intro text. |
| infra/scripts/build_push_images.sh | Adds Bash script to build/push images in ACR via az acr build and update App Services. |
| infra/scripts/build_push_images.ps1 | Adds PowerShell equivalent of the ACR build/push + App Service retargeting script. |
| infra/main.waf.parameters.json | Removes no-longer-needed registry endpoint/image tag parameters. |
| infra/main.parameters.json | Removes no-longer-needed registry endpoint/image tag parameters. |
| infra/main.bicep | Provisions ACR, configures managed identity pulls, updates regions/model defaults, and refreshes monitoring wiring. |
| documents/DeploymentGuide.md | Updates deployment instructions to include the required ACR build/push step before data/agent setup. |
| azure.yaml | Updates postprovision messaging to include the new build/push images step. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
src/App/src/lib/textParsers.ts:210
outroTextextraction is now gated on!firstPartIsProduct. If a message starts directly with a product list (no intro) but includes trailing text after the last product image/link, that trailing text will no longer be emitted asoutroTextand will instead remain inside the last product section (rendered in the last product card).
if (parts.length > 0 && !firstPartIsProduct) {
introText = parts[0].trim();
introText = introText.replace(/^###\s*[^\n]*\n?/gm, '').trim();
Roopan-Microsoft
approved these changes
Jul 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes significant improvements to the deployment process, container registry management, and region/model support. The main changes include automating Azure Container Registry (ACR) provisioning, updating deployment instructions and scripts to reflect the new workflow, and upgrading the default OpenAI model and supported regions. Several obsolete parameters and outputs have been removed to streamline the configuration.
Deployment and Documentation Updates:
Container Registry Automation:
Model and Region Support:
centralusandsouthindia. The default OpenAI model is nowgpt-5.4-miniwith an updated version. [1] [2]Parameter and Output Cleanup:
containerRegistryEndpoint,imageTag) and related outputs have been removed from the Bicep template and parameters files, since registry configuration is now automatic. [1] [2] [3] [4]Monitoring Configuration:
Does this introduce a breaking change?
How to Test
What to Check
Verify that the following are valid
Other Information