fix: address Copilot PR review comments (high & medium priority) by Ashwal-Microsoft · Pull Request #256 · microsoft/customer-chatbot-solution-accelerator

Ashwal-Microsoft · 2026-06-11T07:00:49Z

This pull request includes several improvements across the codebase, focusing on robust data parsing, better error handling, and enhanced logging. The most significant changes are grouped below:

Data Parsing Consistency and Robustness:

Updated all price and number parsing in src/App/src/lib/textParsers.ts to replace all commas (not just the first) before parsing, ensuring correct handling of numbers with thousands separators. This affects the parseOrderItem, parsePrice, and parseProductSection functions. [1] [2] [3]

Error Handling Improvements:

In the E2E test test_28907_golden_path_demo_script, improved handling of the E2E_WARMUP_MS environment variable by adding a try/except block to default to 5000ms and log a warning if the value is invalid.
In the E2E test test_28935_new_session_clears_previous_data, added logging for exceptions during fallback force-click attempts, aiding debugging when the "New Session" button is not clickable.

Logging Configuration:

Fixed the logger configuration in src/api/app/main.py to use the correct logger name (agent_framework.foundry) for error suppression.

API Consistency:

In infra/scripts/agent_scripts/01_create_agents.py, updated create_or_update_prompt_agent to return the agent name directly instead of the result's name, simplifying the return value.- Return base agent name instead of version-scoped ID in create_or_update_prompt_agent

Use global regex replace for comma removal in price parsing (textParsers.ts)
Fix logger name from 'agent_framework_foundry' to 'agent_framework.foundry'
Add defensive parsing for E2E_WARMUP_MS env var
Replace empty except with logged debug message in test_byocc.py

Purpose

...

Does this introduce a breaking change?

Yes
No

What to Check

Verify that the following are valid

...

Other Information

- Return base agent name instead of version-scoped ID in create_or_update_prompt_agent - Use global regex replace for comma removal in price parsing (textParsers.ts) - Fix logger name from 'agent_framework_foundry' to 'agent_framework.foundry' - Add defensive parsing for E2E_WARMUP_MS env var - Replace empty except with logged debug message in test_byocc.py Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

github-actions · 2026-06-11T07:03:05Z

Coverage Report •

File	Stmts	Miss	Cover	Missing
main.py	95	29	69%	57, 69, 71–74, 92, 102, 107, 125–126, 129–131, 134–137, 139–146, 149, 232–233
TOTAL	2400	258	89%

Tests	Skipped	Failures	Errors	Time
402	0 💤	0 ❌	0 🔥	9.892s ⏱️

Copilot

Pull request overview

This PR addresses prior review feedback by tightening up parsing logic, improving test resiliency/diagnostics, and aligning logging/agent-script behavior with how the system is expected to run (Foundry agents by base name, correct logger namespace for suppression).

Changes:

Make numeric/price parsing robust to multiple thousands separators by replacing all commas before parseFloat.
Improve E2E test robustness: defensively parse E2E_WARMUP_MS and log exceptions during fallback click attempts.
Fix Foundry logger suppression to target agent_framework.foundry, and simplify agent creation script return values to the base agent name.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
tests/e2e-test/tests/test_byocc.py	Adds defensive env var parsing and improves logging around fallback click behavior in E2E tests.
src/App/src/lib/textParsers.ts	Uses global comma removal to correctly parse prices/numbers with multiple separators.
src/api/app/main.py	Updates the suppressed logger name to the correct Foundry logger namespace.
infra/scripts/agent_scripts/01_create_agents.py	Returns the base agent name after version creation (rather than a version-scoped result name).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.

+fi

-# Trim whitespace from environment variables to avoid issues with leading/trailing spaces
 SUBSCRIPTION_ID=$(trim "${AZURE_SUBSCRIPTION_ID}")


+    scriptContent: '''
+    param([string]$resourceGroupName, [string]$accountName)
+    $maxRetries = 60
+    $retryCount = 0
+    do {
+      try {
+        $account = Get-AzCognitiveServicesAccount -ResourceGroupName $resourceGroupName -Name $accountName -ErrorAction SilentlyContinue
+        if ($account -and $account.ProvisioningState -eq 'Succeeded') {
+          Write-Output "AI Services provisioning completed with state: $($account.ProvisioningState)"
+          break
+        }
+      } catch {
+        Write-Output "Error checking provisioning state: $_"
+      }
+      $retryCount++
+      if ($retryCount -ge $maxRetries) {
+        Write-Output "Warning: AI Services did not reach terminal state within expected time, proceeding anyway (attempt $retryCount/$maxRetries)"
+        break
+      }
+      Write-Output "Waiting for AI Services provisioning... (attempt $retryCount/$maxRetries)"
+      Start-Sleep -Seconds 5
+    } while ($true)
+    '''


+  identity: {
+    type: 'SystemAssigned'
+  }


+          echo "AZURE_ENV_GPT_MODEL_CAPACITY=${AVAILABLE_CAPACITY:-10}" >> $GITHUB_ENV
+          echo "AZURE_ENV_GPT_MODEL_CAPACITY=${AVAILABLE_CAPACITY:-10}" >> $GITHUB_OUTPUT


Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.

+        CURRENT_VALUE=$(az cognitiveservices usage list --location "$REGION" --query "[?name.value=='$MODEL'].currentValue | [0]" -o tsv 2>/dev/null)
+        LIMIT=$(az cognitiveservices usage list --location "$REGION" --query "[?name.value=='$MODEL'].limit | [0]" -o tsv 2>/dev/null)


+  properties: {
+    azPowerShellVersion: '12.0'
+    scriptContent: '''
+    param([string]$resourceGroupName, [string]$accountName)


+        $account = Get-AzCognitiveServicesAccount -ResourceGroupName $resourceGroupName -Name $accountName -ErrorAction SilentlyContinue
+        if ($account -and $account.ProvisioningState -eq 'Succeeded') {
+          Write-Output "AI Services provisioning completed with state: $($account.ProvisioningState)"
+          break
+        }


+          echo "AZURE_ENV_GPT_MODEL_CAPACITY=${AVAILABLE_CAPACITY:-10}" >> $GITHUB_ENV
+          echo "AZURE_ENV_GPT_MODEL_CAPACITY=${AVAILABLE_CAPACITY:-10}" >> $GITHUB_OUTPUT


…mitted error

…taExceeded early

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.

        echo "  - $MODEL: ${MIN_CAPACITY[$MODEL]}"
    done
    echo "QUOTA_FAILED=true" >> "$GITHUB_ENV"
    exit 0


+          echo "🔍 Checking subscription-wide $SEARCH_TIER tier Azure Search service count..."
+          TOTAL_SERVICES=$(az search service list --subscription ${{ secrets.AZURE_SUBSCRIPTION_ID }} \
+            --query "[?sku.name=='${SEARCH_TIER}'] | length(@)" -o tsv 2>/dev/null || echo "0")


+          # Subscription limits: basic=12, standard=12 (typical defaults)
+          # Use 12 as safe upper bound for both tiers
+          SUBSCRIPTION_LIMIT=12
+          REMAINING=$((SUBSCRIPTION_LIMIT - TOTAL_SERVICES))


    ],
    "webServerFarmResourceName": "[format('asp-{0}', variables('solutionSuffix'))]",
-    "reactAppLayoutConfig": "{\n  \"appConfig\": {\n      \"CHAT_CHATHISTORY\": {\n        \"CHAT\": 70,\n        \"CHATHISTORY\": 30\n      }\n    }\n  }\n}",
+    "reactAppLayoutConfig": "{\r\n  \"appConfig\": {\r\n      \"CHAT_CHATHISTORY\": {\r\n        \"CHAT\": 70,\r\n        \"CHATHISTORY\": 30\r\n      }\r\n    }\r\n  }\r\n}",


Ashwal-Microsoft · 2026-06-15T13:03:58Z

Working on a different issue now, dev to main was resolved earlier

Copilot AI review requested due to automatic review settings June 11, 2026 07:00

Ashwal-Microsoft requested review from Avijit-Microsoft, Roopan-Microsoft, TravisHilbert, brittneek, gpickett, malrose07 and toherman-msft as code owners June 11, 2026 07:00

Ashwal-Microsoft temporarily deployed to production June 11, 2026 07:00 — with GitHub Actions Inactive

Copilot started reviewing on behalf of Ashwal-Microsoft June 11, 2026 07:01 View session

Ashwal-Microsoft temporarily deployed to production June 11, 2026 07:02 — with GitHub Actions Inactive

Ashwal-Microsoft had a problem deploying to production June 11, 2026 07:02 — with GitHub Actions Failure

Copilot AI reviewed Jun 11, 2026

View reviewed changes

Comment thread tests/e2e-test/tests/test_byocc.py Outdated

Ashwal-Microsoft had a problem deploying to production June 11, 2026 07:22 — with GitHub Actions Failure

Ashwal-Microsoft temporarily deployed to production June 11, 2026 09:44 — with GitHub Actions Inactive

Ashwal-Microsoft temporarily deployed to production June 11, 2026 09:47 — with GitHub Actions Inactive

Ashwal-Microsoft temporarily deployed to production June 11, 2026 09:48 — with GitHub Actions Inactive

Ashwal-Microsoft temporarily deployed to production June 11, 2026 09:49 — with GitHub Actions Inactive

Ashwal-Microsoft had a problem deploying to production June 11, 2026 09:51 — with GitHub Actions Failure

Ashwal-Microsoft had a problem deploying to production June 11, 2026 09:52 — with GitHub Actions Failure

Ashwal-Microsoft temporarily deployed to production June 11, 2026 10:16 — with GitHub Actions Inactive

Ashwal-Microsoft temporarily deployed to production June 11, 2026 10:18 — with GitHub Actions Inactive

Ashwal-Microsoft had a problem deploying to production June 11, 2026 10:18 — with GitHub Actions Failure

Ashwal-Microsoft had a problem deploying to production June 11, 2026 10:21 — with GitHub Actions Failure

Ashwal-Microsoft had a problem deploying to production June 15, 2026 11:06 — with GitHub Actions Failure

Ashwal-Microsoft temporarily deployed to production June 15, 2026 11:06 — with GitHub Actions Inactive

Ashwal-Microsoft had a problem deploying to production June 15, 2026 11:07 — with GitHub Actions Failure

fix: restrict quota region selection to allowed AI service regions

5f55609

Copilot AI review requested due to automatic review settings June 15, 2026 11:12

Copilot started reviewing on behalf of Ashwal-Microsoft June 15, 2026 11:12 View session

Copilot AI reviewed Jun 15, 2026

View reviewed changes

fix: add manual region fallback for search quota

e9c8810

Ashwal-Microsoft temporarily deployed to production June 15, 2026 11:21 — with GitHub Actions Inactive

Ashwal-Microsoft temporarily deployed to production June 15, 2026 11:24 — with GitHub Actions Inactive

Ashwal-Microsoft had a problem deploying to production June 15, 2026 11:24 — with GitHub Actions Failure

fix: use user-assigned identity for deployment script

34d9c9d

Copilot AI review requested due to automatic review settings June 15, 2026 11:35

Copilot started reviewing on behalf of Ashwal-Microsoft June 15, 2026 11:36 View session

Ashwal-Microsoft temporarily deployed to production June 15, 2026 11:40 — with GitHub Actions Inactive

Copilot AI reviewed Jun 15, 2026

View reviewed changes

Ashwal-Microsoft temporarily deployed to production June 15, 2026 11:42 — with GitHub Actions Inactive

Ashwal-Microsoft had a problem deploying to production June 15, 2026 11:43 — with GitHub Actions Failure

fix: remove deploymentScripts to resolve KeyBasedAuthenticationNotPer…

c31ec69

…mitted error

Ashwal-Microsoft temporarily deployed to production June 15, 2026 12:11 — with GitHub Actions Inactive

Ashwal-Microsoft temporarily deployed to production June 15, 2026 12:14 — with GitHub Actions Inactive

Ashwal-Microsoft had a problem deploying to production June 15, 2026 12:14 — with GitHub Actions Failure

fix: add subscription-wide Search quota pre-check to catch ServiceQuo…

0aaa3d1

…taExceeded early

Copilot AI review requested due to automatic review settings June 15, 2026 12:22

Copilot started reviewing on behalf of Ashwal-Microsoft June 15, 2026 12:23 View session

Copilot AI reviewed Jun 15, 2026

View reviewed changes

Ashwal-Microsoft closed this Jun 15, 2026

Ashwal-Microsoft temporarily deployed to production June 16, 2026 14:36 — with GitHub Actions Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: address Copilot PR review comments (high & medium priority)#256

fix: address Copilot PR review comments (high & medium priority)#256
Ashwal-Microsoft wants to merge 12 commits into
devfrom
Ash-devtomainCC

Ashwal-Microsoft commented Jun 11, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Jun 11, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Ashwal-Microsoft commented Jun 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		echo "AZURE_ENV_GPT_MODEL_CAPACITY=${AVAILABLE_CAPACITY:-10}" >> $GITHUB_ENV
		echo "AZURE_ENV_GPT_MODEL_CAPACITY=${AVAILABLE_CAPACITY:-10}" >> $GITHUB_OUTPUT

		CURRENT_VALUE=$(az cognitiveservices usage list --location "$REGION" --query "[?name.value=='$MODEL'].currentValue \| [0]" -o tsv 2>/dev/null)
		LIMIT=$(az cognitiveservices usage list --location "$REGION" --query "[?name.value=='$MODEL'].limit \| [0]" -o tsv 2>/dev/null)

Uh oh!

Conversation

Ashwal-Microsoft commented Jun 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Purpose

Does this introduce a breaking change?

What to Check

Other Information

Uh oh!

github-actions Bot commented Jun 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Ashwal-Microsoft commented Jun 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Ashwal-Microsoft commented Jun 11, 2026 •

edited

Loading

github-actions Bot commented Jun 11, 2026 •

edited

Loading