Skip to content

[Android] MATSDK_ANDROID_USE_ROOM=OFF is ignored; AAR always builds with Room #1550

Open

Description

@KartikDhawaniya

Since #1511, lib/android_build/maesdk/src/main/cpp/CMakeLists.txt:9 has:

set(MATSDK_ANDROID_USE_ROOM ON CACHE BOOL "" FORCE)

FORCE overrides the -DMATSDK_ANDROID_USE_ROOM=OFF passed from build.gradle, so the SQLite option described in docs/cpp-start-android.md no longer works.

On v3.10.279.1, with -DMATSDK_ANDROID_USE_ROOM=OFF set in both module build.gradle files:

  • The Gradle-generated CMake command passes -DMATSDK_ANDROID_USE_ROOM=OFF.
  • CMakeCache.txt ends up with MATSDK_ANDROID_USE_ROOM:BOOL=ON.
  • Only OfflineStorage_Room.cpp is compiled, and libmaesdk.so contains no OfflineStorage_SQLite symbols.

Room storage is therefore used even when SQLite is selected, which breaks hosts that don't call OfflineRoom.connectContext().

Separately, the legacy -DUSE_ROOM flag is now silently ignored.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions