Skip to content

Ignore Enter Key for 50ms When Showing New View in Attended Installer #17781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
chriso-ms wants to merge 2 commits into
base: 3.0-dev
Choose a base branch
from
+10 −0
Draft

Ignore Enter Key for 50ms When Showing New View in Attended Installer #17781

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ffc859
add cooldown for Enter key in ISO installer
chriso-ms Jun 22, 2026
f579f30
change to 50ms
chriso-ms Jun 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions toolkit/tools/imagegen/attendedinstaller/attendedinstaller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@ import (
const (
defaultGridWeight = 1

enterCooldown = 50 * time.Millisecond

textRow = 3
textColumn = 0
textRowSpan = 1
Expand Down Expand Up @@ -68,6 +70,7 @@ type AttendedInstaller struct {
grid *tview.Grid
pauseCustomInput bool
pauseSpeakupInput bool
ignoreEnterUntil time.Time
currentView int
allViews []views.View
backdropStyle tview.Theme
Expand Down Expand Up @@ -199,6 +202,9 @@ func (ai *AttendedInstaller) showView(newView int) (err error) {
return
}

// Apply Enter cooldown to all views to prevent carried key events from auto-advancing.
ai.ignoreEnterUntil = time.Now().Add(enterCooldown)

ai.grid.AddItem(view.Primitive(), primaryContentRow, primaryContentColumn, primaryContentRowSpan, primaryContentColumnSpan, primaryContentMinSize, primaryContentMinSize, true)
ai.app.SetFocus(ai.grid)
ai.currentView = newView
Expand All @@ -221,6 +227,10 @@ func (ai *AttendedInstaller) quit() {
}

func (ai *AttendedInstaller) globalInputCapture(event *tcell.EventKey) *tcell.EventKey {
if event.Key() == tcell.KeyEnter && !ai.ignoreEnterUntil.IsZero() && time.Now().Before(ai.ignoreEnterUntil) {
return nil
}

// If we're clearing the speakup buffer, don't process keypresses
// tcell has no easy way of differentiating between keypad enter (speakup clear) and enter
if ai.pauseSpeakupInput && event.Key() == tcell.KeyEnter {
Expand Down
Loading