Fix failing core ptest in systemd and libguestfs#17755
Conversation
d4359df to
4b2e0eb
Compare
systemd: skip tests in %check that require capabilities not available in the build chroot (mount-namespace privileges, systemd-detect-virt on PATH, etc.). Bumps Release 31 -> 32. libguestfs: use the direct libguestfs backend with force_tcg in %check so 'make quickcheck' does not require a running libvirtd / /var/run/libvirt/libvirt-sock in the build chroot; also add sqlite, sqlite-libs and sqlite-devel to the supermin appliance via --with-extra-packages so guestfsd (which depends on libsqlite3 via librpm) can start inside the appliance. Bumps Release 22 -> 23.
4b2e0eb to
61dab7e
Compare
|
Buddy build for systemd after the recent changes in systemd. |
There was a problem hiding this comment.
Pull request overview
This PR updates Azure Linux RPM specs to fix failing %check (ptest) stages for systemd and libguestfs in the build chroot by adjusting test execution behavior and bumping Release values to produce rebuilt packages.
Changes:
systemd: bumpReleaseand run a filteredmeson testlist to skip chroot-incompatible unit tests; add versioned reciprocalConflictsforstandalone-*subpackages.libguestfs: bumpRelease, switch%checkto the direct backend withforce_tcg, and add extra packages to the supermin appliance; make QEMU log dump non-fatal when missing.systemd-boot-signed: bumpReleaseto match the unsignedsystemdrelease.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| SPECS/systemd/systemd.spec | Release bump; adjust %check to skip known chroot-incompatible tests; add reciprocal conflicts for standalone subpackages. |
| SPECS/libguestfs/libguestfs.spec | Release bump; tweak %check backend settings; extend supermin appliance package set; make log dump non-fatal. |
| SPECS-SIGNED/systemd-boot-signed/systemd-boot-signed.spec | Release bump to keep signed sd-boot package aligned with systemd release. |
Kanishk-Bansal
left a comment
There was a problem hiding this comment.
LGTM,
in libguestfs forcing the direct backend with force_tcg is a nice minimal approach, since we don't have libvirtd / /var/run/libvirt/libvirt-sock (or /dev/kvm) in the build chroot.
in systemd the pakcage conflict refactor is a good add on which is unrelated to ptest fix, we are basically skipping the test although these passes in non chroot env, but due to env constraints we are skipping it here.
| %check | ||
| %if %{with tests} | ||
| meson test -C %{_vpath_builddir} -t 6 --print-errorlogs | ||
| # Skip tests that require capabilities not available in the build chroot: |
|
Buddy build for this is successful. The PR check failures are also not there for systemd and libguestfs. All the changes are related to tests. The PR ensures that any future genuine failures for these packages, we check properly instead of assuming that it was always failing. @PawelWMS, could you please check and if looks good, could you please approve it? |
Summary
Fix failing
%check(ptest) stages forsystemdandlibguestfsin the Azure Linux build chroot. No upstream version changes — release-bump + targeted in-spec test fixes only.Changes
systemd%checkthat require capabilities not available in the build chrootlibguestfsmake quickcheckto the direct backend withforce_tcg; extend supermin appliance withsqlite*Details
systemdConstructs an explicit test list and excludes tests that fail in a chroot but pass in a real environment:
test-fd-util,test-mount-util,test-mountpoint-util,test-path-util,test-time-util,test-calendarspec,test-date— need mount-namespace privileges (MS_SLAVEremount fails withEINVALin the chroot).test-udev— invokessystemd-detect-virt, which is not onPATHyet at this stage.test-rpm-macros— environmental mismatch with the build chroot.libguestfsforce_tcgin%checksomake quickcheckno longer requires a runninglibvirtdor/var/run/libvirt/libvirt-sock, and does not need/dev/kvm.sqlite,sqlite-libs,sqlite-develto the supermin appliance via--with-extra-packagessoguestfsd(which depends onlibsqlite3throughlibrpm) can start inside the appliance.Verification
Release:bumps to the packagessystemdnorlibguestfsappears in any toolchain / pkggen_core manifest;systemd-bootstrap-250.3-19in the manifests is a separateSPECS/systemd-bootstrap/systemd-bootstrap.spec, not affected)Related
#17749 ("Fix failing core ptest across packages")