Skip to content

Fix failing core ptest in systemd and libguestfs#17755

Open
kgodara912 wants to merge 1 commit into
3.0-devfrom
kgodara/3.0-dev/ptest_fixes_systemd_libguestfs
Open

Fix failing core ptest in systemd and libguestfs#17755
kgodara912 wants to merge 1 commit into
3.0-devfrom
kgodara/3.0-dev/ptest_fixes_systemd_libguestfs

Conversation

@kgodara912

@kgodara912 kgodara912 commented Jun 17, 2026

Copy link
Copy Markdown

Summary

Fix failing %check (ptest) stages for systemd and libguestfs in the Azure Linux build chroot. No upstream version changes — release-bump + targeted in-spec test fixes only.

Changes

Package Fix
systemd Skip tests in %check that require capabilities not available in the build chroot
libguestfs Switch make quickcheck to the direct backend with force_tcg; extend supermin appliance with sqlite*

Details

systemd

Constructs an explicit test list and excludes tests that fail in a chroot but pass in a real environment:

  • test-fd-util, test-mount-util, test-mountpoint-util, test-path-util, test-time-util, test-calendarspec, test-date — need mount-namespace privileges (MS_SLAVE remount fails with EINVAL in the chroot).
  • test-udev — invokes systemd-detect-virt, which is not on PATH yet at this stage.
  • test-rpm-macros — environmental mismatch with the build chroot.

libguestfs

  • Force the direct libguestfs backend with force_tcg in %check so make quickcheck no longer requires a running libvirtd or /var/run/libvirt/libvirt-sock, and does not need /dev/kvm.
  • Add sqlite, sqlite-libs, sqlite-devel to the supermin appliance via --with-extra-packages so guestfsd (which depends on libsqlite3 through librpm) can start inside the appliance.
  • Make the QEMU log dump on failure non-fatal when the log directory is missing.

Verification

  • Both Release: bumps to the packages
  • No upstream version changes
  • No toolchain manifest update needed (neither systemd nor libguestfs appears in any toolchain / pkggen_core manifest; systemd-bootstrap-250.3-19 in the manifests is a separate SPECS/systemd-bootstrap/systemd-bootstrap.spec, not affected)

Related

#17749 ("Fix failing core ptest across packages")

@kgodara912

Copy link
Copy Markdown
Author

Buddy build

@kgodara912 kgodara912 force-pushed the kgodara/3.0-dev/ptest_fixes_systemd_libguestfs branch from d4359df to 4b2e0eb Compare June 17, 2026 17:19
@microsoft-github-policy-service microsoft-github-policy-service Bot added the 3.0-dev PRs Destined for AzureLinux 3.0 label Jun 17, 2026
@kgodara912 kgodara912 added the ptest package testing (%check section in spec) label Jun 17, 2026
systemd: skip tests in %check that require capabilities not available
in the build chroot (mount-namespace privileges, systemd-detect-virt
on PATH, etc.). Bumps Release 31 -> 32.

libguestfs: use the direct libguestfs backend with force_tcg in %check
so 'make quickcheck' does not require a running libvirtd /
/var/run/libvirt/libvirt-sock in the build chroot; also add sqlite,
sqlite-libs and sqlite-devel to the supermin appliance via
--with-extra-packages so guestfsd (which depends on libsqlite3 via
librpm) can start inside the appliance. Bumps Release 22 -> 23.
@kgodara912 kgodara912 force-pushed the kgodara/3.0-dev/ptest_fixes_systemd_libguestfs branch from 4b2e0eb to 61dab7e Compare June 18, 2026 07:42
@kgodara912

Copy link
Copy Markdown
Author

Buddy build for systemd after the recent changes in systemd.

@kgodara912 kgodara912 marked this pull request as ready for review June 19, 2026 06:02
@kgodara912 kgodara912 requested a review from a team as a code owner June 19, 2026 06:02
@kgodara912 kgodara912 requested a review from Copilot June 19, 2026 06:21

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Azure Linux RPM specs to fix failing %check (ptest) stages for systemd and libguestfs in the build chroot by adjusting test execution behavior and bumping Release values to produce rebuilt packages.

Changes:

  • systemd: bump Release and run a filtered meson test list to skip chroot-incompatible unit tests; add versioned reciprocal Conflicts for standalone-* subpackages.
  • libguestfs: bump Release, switch %check to the direct backend with force_tcg, and add extra packages to the supermin appliance; make QEMU log dump non-fatal when missing.
  • systemd-boot-signed: bump Release to match the unsigned systemd release.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
SPECS/systemd/systemd.spec Release bump; adjust %check to skip known chroot-incompatible tests; add reciprocal conflicts for standalone subpackages.
SPECS/libguestfs/libguestfs.spec Release bump; tweak %check backend settings; extend supermin appliance package set; make log dump non-fatal.
SPECS-SIGNED/systemd-boot-signed/systemd-boot-signed.spec Release bump to keep signed sd-boot package aligned with systemd release.

Comment thread SPECS/libguestfs/libguestfs.spec
Comment thread SPECS-SIGNED/systemd-boot-signed/systemd-boot-signed.spec

@Kanishk-Bansal Kanishk-Bansal left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,

in libguestfs forcing the direct backend with force_tcg is a nice minimal approach, since we don't have libvirtd / /var/run/libvirt/libvirt-sock (or /dev/kvm) in the build chroot.

in systemd the pakcage conflict refactor is a good add on which is unrelated to ptest fix, we are basically skipping the test although these passes in non chroot env, but due to env constraints we are skipping it here.

Comment thread SPECS/libguestfs/libguestfs.spec
%check
%if %{with tests}
meson test -C %{_vpath_builddir} -t 6 --print-errorlogs
# Skip tests that require capabilities not available in the build chroot:

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@Kanishk-Bansal Kanishk-Bansal added the ready-for-stable-review PR has passed initial review and is now ready for a second-level stable maintainer review label Jun 19, 2026
@kgodara912

Copy link
Copy Markdown
Author

Buddy build for this is successful. The PR check failures are also not there for systemd and libguestfs. All the changes are related to tests. The PR ensures that any future genuine failures for these packages, we check properly instead of assuming that it was always failing. @PawelWMS, could you please check and if looks good, could you please approve it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.0-dev PRs Destined for AzureLinux 3.0 Packaging ptest package testing (%check section in spec) ready-for-stable-review PR has passed initial review and is now ready for a second-level stable maintainer review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants