Fix dashboard app names with dash suffix - #19932
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Copilot Share the ApplicationNameRegex. avoid duplication |
Co-authored-by: JamesNK <303201+JamesNK@users.noreply.github.com>
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 19932Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 19932" |
|
What happens if the name is just What about tests for if there is no seperator, e.g. "TestShopAppHost". |
This comment has been minimized.
This comment has been minimized.
Co-authored-by: JamesNK <303201+JamesNK@users.noreply.github.com>
Tests selector49 / 99 PR test projects · 4 PR jobs · 2 advisory-only targets, from 5 changed files. Selected PR test projects (49 / 99)
Selected PR jobs (4)
Advisory workflow impact (2)
How these were chosen — grouped by what changed
🔧 show 45
🧪 📦 affected project 🧪 Job reasons
Selection computed for commit |
Description
Source-file AppHosts can derive their dashboard application name from a directory such as
aspire-apphost. The existing suffix normalization only recognized an optional.beforeAppHost, causing the dashboard to displayaspire-.This change recognizes both
.and-separators before theAppHostsuffix. The same handling is applied to DCP resource-name normalization, with regression coverage for both naming forms.User-facing usage
Dashboard application names now normalize as follows:
Validation: regression tests were added to
DashboardServiceTestsandDcpExecutorTests. The test project could not be restored in the agent environment because the configured internal Arcade package feed returned HTTP 403.Fixes # (issue)
Checklist
<remarks />and<code />elements on your triple slash comments?Created from a Microsoft Teams conversation.