Improve XML comments for CustomResourceSnapshot.HealthReports property - #19930
Open
Pasi Savolainen (pasisavolainen) wants to merge 1 commit into
Open
Improve XML comments for CustomResourceSnapshot.HealthReports property#19930Pasi Savolainen (pasisavolainen) wants to merge 1 commit into
Pasi Savolainen (pasisavolainen) wants to merge 1 commit into
Conversation
Hint for HealthReports property updating mechanism.
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 19930Or
iex "& { $(irm https://raw.githubusercontent.com/microsoft/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 19930" |
Copilot started reviewing on behalf of
Pasi Savolainen (pasisavolainen)
September 4, 2026 11:25
View session
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Only a non-blocking documentation wording nit remains.
Pull request overview
Improves discoverability of the supported health-report update mechanism.
Changes:
- Links
HealthReportsdocumentation toWithHealthReports.
File summaries
| File | Review |
|---|---|
src/Aspire.Hosting/ApplicationModel/CustomResourceSnapshot.cs |
Adds update guidance; minor wording nit: clarify that WithHealthReports returns a new snapshot rather than modifying the original. |
Review details
Suppressed comments (1)
src/Aspire.Hosting/ApplicationModel/CustomResourceSnapshot.cs:91
- This wording implies that
WithHealthReportsmodifies the existing snapshot, but the method returns a new record copy and leaves the original unchanged. Describe the copy semantics so callers do not discard the returned value.
/// Use <see cref="CustomResourceSnapshotExtensions.WithHealthReports"/> to modify.
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hint for CustomResourceSnapshot.HealthReports property updating mechanism.
Description
HealthReports appears to be
internal initwithout clear mechanism on how to update, but there is this extension that is only discoverable by browsing sourcesChecklist
<remarks />and<code />elements on your triple slash comments?