Fix VS Code resource command file inputs - #19895
Open
Copilot wants to merge 1 commit into
Open
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
VS Code resource commands invoked from the tree or CodeLens silently canceled when a command declared an
InputType.Fileargument. The extension did not recognize file inputs in the resource-command contract, so commands such as "Import bingo squares" never displayed a picker.This change adds end-to-end support for those arguments:
InteractionInput.GetFiles().User-facing usage
Given a resource command argument such as:
clicking the command's CodeLens or tree action now opens the VS Code file picker. The command callback receives a managed file:
Screenshots / Recordings
TODO: Capture the "Import bingo squares" CodeLens opening VS Code's native file picker. The extension build could not be bootstrapped in this environment because the configured Corepack package download returned HTTP 403.
Validation
git diff --checkand localization JSON/source checks pass.Security considerations
The extension and AppHost exchange local file paths because both execute in the same local or remote workspace trust boundary. The AppHost normalizes each path, verifies that the file exists, enforces the configured file-count, extension, and size limits, and performs a bounded copy into repository-managed temporary storage. The copy is size-checked while streaming to prevent a file from growing beyond the limit after the initial metadata check. A security review has not yet been performed.
Fixes # (issue)
Created from a Microsoft Teams conversation.
Checklist
<remarks />and<code />elements on your triple slash comments?