Fix duplicate password reveal icon - #19894
Open
Copilot wants to merge 1 commit into
Open
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot
AI
requested review from
James Newton-King (JamesNK) and
Adam Ratzman (adamint)
as code owners
September 3, 2026 15:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Secret text fields in the unresolved parameters dialog could briefly show two reveal icons in Microsoft Edge: the browser-provided password reveal control and Aspire's custom accessible reveal button. The dialog now suppresses Edge's native control inside the Fluent text field's shadow DOM before rendering Aspire's button, so exactly one reveal affordance is visible.
The suppression is idempotent, applies to every secret field, and is retried when dialog content is re-rendered. Component coverage verifies that the native control is suppressed before one custom button is rendered, and browser coverage verifies that the suppression style is installed inside the Fluent component's shadow root.
User-facing usage
When an unresolved parameter uses the secret text input type, the dashboard displays one reveal button beside the masked value instead of briefly displaying two.
Screenshots / Recordings
TODO: Capture the unresolved parameters dialog with a pre-populated secret value in Microsoft Edge. Before this change, the native and Aspire reveal icons briefly overlap; after this change, only Aspire's reveal button is shown.
Validation: JavaScript syntax and focused helper behavior pass locally. The targeted dashboard component test could not run because the configured dnceng Arcade SDK feed returned HTTP 403 while restoring
Microsoft.DotNet.Arcade.Sdk.Fixes # (issue)
Checklist
<remarks />and<code />elements on your triple slash comments?Created from a Microsoft Teams conversation.