actionGrammar: replace GrammarWriter with 2-pass compact-first formatter#1974
Merged
curtisman merged 2 commits intomicrosoft:mainfrom Mar 3, 2026
Merged
Conversation
Refactor GrammarWriter to use an IR-based two-pass layout algorithm (build pass + render pass) that produces compact, single-line output when it fits within maxLineLength and gracefully expands to multi-line when it doesn't. Key changes: - Add IR node types: NewlinePart, ListPart, BlockPart, GroupPart - Add measureParts() for flat-length measurement and renderParts() for column-tracking render - Add GrammarWriter helpers: capture(), emitParts(), emitList(), emitBlock(), emitGroup() - Rules, arrows (->), objects, arrays, inline groups, and expression sequences all independently choose flat vs broken based on available column space - Add comprehensive layout test suite in grammarRuleWriter.spec.ts covering all five formatting rules with exact-limit and round-trip cases Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
curtisman
had a problem deploying
to
development-fork
GitHub Actions
Error
curtisman
had a problem deploying
to
development-fork
GitHub Actions
Error
curtisman
requested a deployment
to
development-fork
GitHub Actions
Waiting
curtisman
requested a deployment
to
development-fork
GitHub Actions
Waiting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GrammarWriterto use an IR-based two-pass layout algorithm (build pass + render pass) that produces compact single-line output when it fits withinmaxLineLengthand gracefully expands to multi-line when it doesn'tNewlinePart,ListPart,BlockPart,GroupPart) and rendering helpers (measureParts,renderParts,capture,emitParts,emitList,emitBlock,emitGroup)->arrows, objects{}, arrays[], inline expression groups, and expression-sequence wrapping) independently choose flat vs broken form based on actual column position at render time🤖 Generated with Claude Code