fix: the RFP team table formatting#1066
Open
Ayaz-Microsoft wants to merge 5 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes Bug 47810 by ensuring collapsed/flattened GitHub Flavored Markdown (GFM) tables are normalized into multi-line table blocks in final responses (not just “AI thinking”), improving UI rendering consistency.
Changes:
- Introduces shared markdown table repair utilities to reflow single-line (collapsed) tables into proper multi-line GFM tables.
- Applies table normalization to final orchestration output and to the final (non-streaming) agent response callback.
- Adds orchestration-focused tests covering normalization behavior for common collapsed-table patterns.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/tests/backend/orchestration/test_orchestration_manager.py | Adds tests for collapsed-table normalization and injects the real markdown utility module into mocked imports. |
| src/backend/orchestration/orchestration_manager.py | Normalizes collapsed markdown tables before embedding bare image URLs in the final orchestration response. |
| src/backend/common/utils/markdown_utils.py | New utility module implementing collapsed-table detection and reflow logic. |
| src/backend/callbacks/response_handlers.py | Normalizes collapsed markdown tables before sending the final websocket message. |
| src/backend/api/router.py | Minor formatting/whitespace adjustment only. |
| conftest.py | Minor formatting cleanup (trailing whitespace / spacing). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ponses Repairs GFM tables whose rows get flattened onto a single physical line so react-markdown/remark-gfm renders them as proper tables instead of raw pipes. Adds a shared common/utils/markdown_utils.py used by both the orchestrator final-answer path and the agent_response_callback (Group Chat Manager) path. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This PR fixes bug(47810) where the RFP team table is properly formatted in AI thinking, but not in the final response
Does this introduce a breaking change?
How to Test
What to Check
Verify that the following are valid
Other Information