Redesign the status bar with structured counts and scoped aria-live#646
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Redesigns the UI status bar into a structured left/right layout with culture-aware count formatting and a scoped screen-reader announcement region, addressing the prior aria-live behavior that re-announced the entire bar on frequent count updates.
Changes:
- Reworks
StatusBarmarkup/CSS to split persistent (source/counts/filter indicator) vs transient activity, and confines announcements to a hiddenrole="status"region. - Introduces
StatusBarFormatterto centralize pure formatting logic for source labels, counts, filter tooltip text, and activity announcements. - Adds
FilterPaneState.IsFilteringEnabledand unit tests to lock its behavior toFilterPaneFilterBuilder.Build(state).IsFilteringEnabled, plus bUnit coverage for the status bar accessibility/behavior.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/Unit/EventLogExpert.UI.Tests/StatusBar/StatusBarTests.cs | Adds bUnit coverage for new status bar structure, filter/lens behavior, and aria-live scoping. |
| tests/Unit/EventLogExpert.Runtime.Tests/StatusBar/StatusBarFormatterTests.cs | Adds unit tests for status bar formatting helpers (source/counts/tooltips/announcement priority). |
| tests/Unit/EventLogExpert.Runtime.Tests/FilterPane/FilterPaneStateFilteringTests.cs | Locks FilterPaneState.IsFilteringEnabled behavior to the existing builder output to prevent drift. |
| src/EventLogExpert.UI/StatusBar/StatusBar.razor.css | Implements new flex-based left/right layout and screen-reader-only announce region styling. |
| src/EventLogExpert.UI/StatusBar/StatusBar.razor.cs | Updates Fluxor selections (buffer count + selection count) and adds selections for persistent filter and lens count. |
| src/EventLogExpert.UI/StatusBar/StatusBar.razor | Replaces single live region with structured layout and a dedicated announce-only live region; moves count/source rendering to formatter. |
| src/EventLogExpert.Runtime/StatusBar/StatusBarFormatter.cs | New formatter providing pure presentation helpers for status bar strings and tooltip/announcement logic. |
| src/EventLogExpert.Runtime/FilterPane/FilterPaneState.cs | Adds computed IsFilteringEnabled for persistent-filter indicator logic. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
e2d633e to
de35f3f
Compare
NikTilton
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the ad-hoc status bar (a flat row of spans in one
aria-liveregion) with a structured left/right layout and fixes a real screen-reader accessibility defect.Tracks ADO 63067058. Base is
main(independent of the still-open time-window PR #645; no file overlap).Design
Shaped by a 5-reviewer UX design panel: left/right split (VS-Code-style persistent-vs-transient), thousands-separated counts, a compact read-only filter indicator (the lens breadcrumb above the table owns the removable chips), source = active tab only, and the accessibility model below.
Accessibility fix (the core of the ADO)
The old bar was a single
aria-live="polite" aria-atomic="true"region, so a screen reader re-announced the entire bar on every count tick - driven by the unthrottled event-count and per-event live-buffer counters.aria-live/role/aria-atomic. Counts and source update silently.role="status" aria-live="polite"region carries only a coarse, transition-only label (load error / buffer full / loading / continuously updating), so it announces on state changes, not on numeric ticks.aria-live="off".Key correctness
AppliedFilter.IsFilteringEnabled(base intersect lenses), so a lens-only narrowing correctly shows "M of N shown" - and a new publicFilterPaneState.IsFilteringEnableddistinguishes the persistent filter for the tooltip (drift-locked toFilterPaneFilterBuilder.Build).returnthat could drop the activity region.LogView.ComputerNameis the event-origin machine, not the connection source - deferred to v2).Implementation
FilterPaneState.IsFilteringEnabled(public computed, allocation-free).StatusBarFormatter(public static, Runtime, mirrorsEventTableColumnFormatter): source / counts / filter-tooltip / activity-announcement.StatusBar.razor(.cs/.css)restructured; newIStateSelectionprojectors for the persistent-filter bool and lens count.Tests (34 new)
StatusBarFormatterTests(formatter variants, culture-robust counts, error-over-loading priority).FilterPaneStateFilteringTests(locksIsFilteringEnabled==Build(state).IsFilteringEnabledacross 7 states).StatusBarTests(bUnit: root not live / announce region isrole=status, "No log open", shown-iff-filtered, selected only at N>=2, "New Events" isaria-live=off, lens-only narrowing shows counts + "N lenses").Validation
Runtime.Tests 1716/1716, UI.Tests 1045/1045, full-solution Release build 0 warnings / 0 errors.
Deferred to v2
Indicator interactivity (click-to-focus), remote-source indication, a color-coded status palette meeting WCAG AA on the status-bar fill, focused-row position, an explicit "Hidden" count, and aria transition-coalescing.