Update switching from LEAST() to CASE for NBRecordsEligible#506
Open
VBD-BYoung wants to merge 1 commit intomicrosoft:masterfrom
Open
Update switching from LEAST() to CASE for NBRecordsEligible#506VBD-BYoung wants to merge 1 commit intomicrosoft:masterfrom
VBD-BYoung wants to merge 1 commit intomicrosoft:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change replaces the use of the LEAST() function inside the RemoveOrphansOnTablesWithoutDateTime stored procedure with a SQL Server–compliant CASE expression.
Recent versions of SqlPackage/DacFx (v162+) now perform strict validation of stored procedure bodies during BACPAC imports. As part of that validation, the procedure is parsed and compiled using SQL Server’s T‑SQL rules. Because SQL Server does not support the LEAST() function, the BACPAC import fails with:
Older SqlPackage versions did not validate SP bodies at this level, which is why this had not surfaced previously.
To restore compatibility, the call to LEAST(@NBRecordsEligible, @batchsize) has been replaced with the equivalent conditional expression:
This maintains identical behavior but ensures SQL Server and SqlPackage accept the procedure during deployment.
No functional or behavioral changes beyond this fix. This update resolves the BACPAC import failure and aligns the stored procedure with T‑SQL standards.