fix: merging dev to main#663
Conversation
…ript docs: quota script check updated
feat: replace role name with GUID
|
@Priyanka1-Microsoft please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
There was a problem hiding this comment.
Pull request overview
This pull request updates the quota-check defaults for the OpenAI model/capacity pair and standardizes Azure RBAC role assignment identifiers in the infrastructure templates by using explicit role definition GUIDs.
Changes:
- Updated quota-check defaults to use
gpt4.1-miniwith capacity150(and aligned the QuotaCheck documentation examples). - Replaced RBAC role display names with role definition GUIDs in
infra/main.bicepand regeneratedinfra/main.jsonaccordingly. - Updated the generated template hash in
infra/main.json.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| infra/main.bicep | Switches role assignment inputs from role names to role definition GUIDs (with inline comments for readability). |
| infra/main.json | Regenerated ARM template reflecting role GUID updates and updated template hash. |
| docs/QuotaCheck.md | Updates default model/capacity examples to gpt4.1-mini:150. |
| Deployment/quota_check_params.sh | Updates default model/capacity pair used by the quota-check script. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| Before deploying the accelerator, **ensure sufficient quota availability** for the required model. | ||
| > **For Global Standard | GPT-4o-mini - increase the capacity to at least 150K tokens for optimal performance.** | ||
| > **For Global Standard | gpt4.1-mini - increase the capacity to at least 150K tokens for optimal performance.** |
| # Default Models and Capacities (Comma-separated in "model:capacity" format) | ||
| DEFAULT_MODEL_CAPACITY="gpt-4o-mini:100,text-embedding-3-large:100" | ||
| DEFAULT_MODEL_CAPACITY="gpt4.1-mini:150,text-embedding-3-large:100" |
chore: Removing create-release.yml file
Purpose
This pull request updates default model names and capacities for quota checks, and standardizes Azure role assignments in the infrastructure code by replacing role names with their corresponding GUIDs. Documentation and sample commands are updated to reflect these changes.
Model and Capacity Updates:
gpt-4o-minitogpt4.1-miniand increased its default capacity from 100 to 150 in bothquota_check_params.shand related documentation. [1] [2] [3] [4]Infrastructure Role Assignment Updates:
roleDefinitionIdOrNameassignments ininfra/main.bicepand the generatedinfra/main.jsonto ensure clarity and avoid ambiguity during deployment. This affects roles such asAcrPull,App Configuration Data Reader,Storage Blob Data Contributor,Search Index Data Contributor,Search Index Data Reader,Cognitive Services OpenAI Contributor,Cognitive Services OpenAI User,Cognitive Services User, andContributor. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14]Documentation and Sample Command Updates:
docs/QuotaCheck.mdto match the new default model name and capacity, ensuring consistency across documentation and code. [1] [2] [3]Template Hash Update:
infra/main.jsonto reflect the changes in the infrastructure code.Does this introduce a breaking change?
Golden Path Validation
Deployment Validation
What to Check
Verify that the following are valid
Other Information