salvage: protect path lookahead std::max from Windows macros (credit @2750666716 #4788) - #9803
Open
Bartok9 wants to merge 1 commit into
Open
Conversation
Credit @2750666716 microsoft#4788 for identifying the MSVC macro pitfall. Land only the portable (std::max) form — omit Sleep/windows.h which are non-portable and change path following latency. Signed-off-by: Bartok9 <danielrpike9@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
std::maxas(std::max)(...)so MSVC Windowsmaxmacros cannot break the call.Motivation / differential value vs #4788
Open #4788 also proposes
#include <windows.h>+Sleep(30)in the path loop. That is non-portable and changes path-following latency on every iteration. This salvage keeps only the portable macro-safestd::maxform identified in that PR.(std::max)lookaheadSleep(30)/windows.hRecommend: merge this micro-fix; original #4788 can close or drop the Sleep path.
Verification
MultirotorApiBase.cpponlyAgent-Owner:
sera· Platform: hermes · Claim-TTL: 24h